linux-kernel - Re: [PATCH 2/3] arm64: dts: rockchip: use SCMI clock id for cpu clock on rk356x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5996423.DvuYhMxLoT@phil>
Date: Thu, 06 Nov 2025 00:43:26 +0100
From: Heiko Stuebner <heiko@...ech.de>
To: Diederik de Haas <diederik@...ow-tech.com>
Cc: mturquette@...libre.com, sboyd@...nel.org, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, linux-clk@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
 linux-kernel@...r.kernel.org, michael.riesch@...labora.com
Subject:
 Re: [PATCH 2/3] arm64: dts: rockchip: use SCMI clock id for cpu clock on
 rk356x

Am Mittwoch, 5. November 2025, 14:16:42 Mitteleuropäische Normalzeit schrieb Diederik de Haas:
> Hi Heiko,
> 
> On Tue Nov 4, 2025 at 12:49 AM CET, Heiko Stuebner wrote:
> > Instead of hard-coding 0, use the more descriptive ID from the binding
> > to reference the SCMI clock for the cpu on rk356x.
> 
> Any particular reason you only did it for the cpu, but not the gpu?

Didn't think of if at the time :-) .

Will prepare another one for the GPU.


Heiko

> 
> > Signed-off-by: Heiko Stuebner <heiko@...ech.de>
> > ---
> >  arch/arm64/boot/dts/rockchip/rk356x-base.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
> > index a3361527d4fe..d0c76401b45e 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
> > +++ b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
> > @@ -53,7 +53,7 @@ cpu0: cpu@0 {
> >  			device_type = "cpu";
> >  			compatible = "arm,cortex-a55";
> >  			reg = <0x0 0x0>;
> > -			clocks = <&scmi_clk 0>;
> > +			clocks = <&scmi_clk SCMI_CLK_CPU>;
> 
> Regardless of the above comment, feel free to add
> 
> Reviewed-by: Diederik de Haas <diederik@...ow-tech.com>
> 
> Cheers,
>   Diederik
> 
> >  			#cooling-cells = <2>;
> >  			enable-method = "psci";
> >  			i-cache-size = <0x8000>;
> 
>