linux-kernel - RE: [PATCH v2 2/5] remoteproc: imx_rproc: Add runtime ops copy to support dynamic behavior

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB84592657431777C58019A8C588C5A@PAXPR04MB8459.eurprd04.prod.outlook.com>
Date: Wed, 5 Nov 2025 08:47:47 +0000
From: Peng Fan <peng.fan@....com>
To: Iuliana Prodan <iuliana.prodan@....com>, Bjorn Andersson
	<andersson@...nel.org>, Mathieu Poirier <mathieu.poirier@...aro.org>, Rob
 Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor
 Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>, Sascha Hauer
	<s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>, Daniel Baluta <daniel.baluta@....com>,
	Frank Li <frank.li@....com>
CC: "linux-remoteproc@...r.kernel.org" <linux-remoteproc@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 2/5] remoteproc: imx_rproc: Add runtime ops copy to
 support dynamic behavior

> Subject: Re: [PATCH v2 2/5] remoteproc: imx_rproc: Add runtime ops
> copy to support dynamic behavior
> 
> > -1056,6 +1052,9 @@ static int imx_rproc_probe(struct
> platform_device *pdev)
> >   	priv->dcfg = dcfg;
> >   	priv->dev = dev;
> >
> > +	if (dcfg->ops)
> > +		priv->ops = dcfg->ops;
> 
> Will priv->ops ever be modified after initialization in a multi-threaded
> context?
> If so, you might need synchronization.

This is in probe phase, no multi-thread context.

> 
> Also, you can remove the NULL check since it's safe to assign NULL.

Yes.

Thanks,
Peng.

> 
> Iulia
> 
> > +
> >   	dev_set_drvdata(dev, rproc);
> >   	priv->workqueue = create_workqueue(dev_name(dev));
> >   	if (!priv->workqueue) {
> >