linux-kernel - Re: [PATCH] btrfs: scrub: fix memory leak in scrub_raid56_parity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e8aa994-a7aa-43f7-86b9-9dec69624167@gmx.com>
Date: Wed, 5 Nov 2025 19:23:18 +1030
From: Qu Wenruo <quwenruo.btrfs@....com>
To: Zilin Guan <zilin@....edu.cn>, clm@...com
Cc: dsterba@...e.com, linux-btrfs@...r.kernel.org,
 linux-kernel@...r.kernel.org, jianhao.xu@....edu.cn
Subject: Re: [PATCH] btrfs: scrub: fix memory leak in
 scrub_raid56_parity_stripe()



在 2025/11/5 14:23, Zilin Guan 写道:
> scrub_raid56_parity_stripe() allocates a bio with bio_alloc(), but
> fails to release it on some error paths, leading to a potential
> memory leak.
> 
> Add the missing bio_put() calls to properly drop the bio reference
> in those error cases.
> 
> Fixes: 1009254bf22a3 ("btrfs: scrub: use scrub_stripe to implement RAID56 P/Q scrub")
> Signed-off-by: Zilin Guan <zilin@....edu.cn>

Reviewed-by: Qu Wenruo <wqu@...e.com>

Merged into for-next branch.

Thanks,
Qu
> ---
>   fs/btrfs/scrub.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/fs/btrfs/scrub.c b/fs/btrfs/scrub.c
> index 651b11884f82..ba20d9286a34 100644
> --- a/fs/btrfs/scrub.c
> +++ b/fs/btrfs/scrub.c
> @@ -2203,6 +2203,7 @@ static int scrub_raid56_parity_stripe(struct scrub_ctx *sctx,
>   	ret = btrfs_map_block(fs_info, BTRFS_MAP_WRITE, full_stripe_start,
>   			      &length, &bioc, NULL, NULL);
>   	if (ret < 0) {
> +		bio_put(bio);
>   		btrfs_put_bioc(bioc);
>   		btrfs_bio_counter_dec(fs_info);
>   		goto out;
> @@ -2212,6 +2213,7 @@ static int scrub_raid56_parity_stripe(struct scrub_ctx *sctx,
>   	btrfs_put_bioc(bioc);
>   	if (!rbio) {
>   		ret = -ENOMEM;
> +		bio_put(bio);
>   		btrfs_bio_counter_dec(fs_info);
>   		goto out;
>   	}