linux-kernel - Re: [PATCH v7 1/7] dt-bindings: arm: Add support for Qualcomm TGU trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <38452e04-255e-477d-8262-53aeb3c87a01@kernel.org>
Date: Wed, 5 Nov 2025 10:03:04 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Songwei Chai <songwei.chai@....qualcomm.com>
Cc: andersson@...nel.org, alexander.shishkin@...ux.intel.com,
 kernel@....qualcomm.com, mike.leach@...aro.org, suzuki.poulose@....com,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-arm-msm@...r.kernel.org, coresight@...ts.linaro.org,
 devicetree@...r.kernel.org
Subject: Re: [PATCH v7 1/7] dt-bindings: arm: Add support for Qualcomm TGU
 trace

On 05/11/2025 09:49, Songwei Chai wrote:
> 
> On 11/5/2025 4:15 PM, Krzysztof Kozlowski wrote:
>> On 05/11/2025 09:11, Songwei Chai wrote:
>>> On 11/5/2025 3:49 PM, Krzysztof Kozlowski wrote:
>>>> On Mon, Nov 03, 2025 at 10:40:37PM -0800, Songwei Chai wrote:
>>>>> The Trigger Generation Unit (TGU) is designed to detect patterns or
>>>>> sequences within a specific region of the System on Chip (SoC). Once
>>>>> configured and activated, it monitors sense inputs and can detect a
>>>>> pre-programmed state or sequence across clock cycles, subsequently
>>>>> producing a trigger.
>>>>>
>>>> I do not understand: You got review which you ignored and then you
>>>> removed pieces of this code to make it incorrect. Go back to previous
>>>> versions so you won't waste our time re-doing review.
>>> Hi Krzysztof,
>>>
>>> The previous reviewed-by is no longer applicable because in this
>>> version, we moved
>>>
>>> the driver from /drivers/hwtracing/coresight/ to
>>> /drivers/hwtracing/qcom/. This means the
>>>
>>> required compatible has changed from "/qcom,coresight-tgu/" to "/qcom,tgu/".
>>>
>>> Since this involves changes to devicetree binding, i didn't not carry
>>> over the previous review tags.
>> And which part of changelog explains the exact reasons to drop review
>> tags? Not mentioning that changelog is almost impossible to find, buried
>> under 10 pages of some repetitive introduction
>>
>> Did you read submitting patches?
> 
> As I mentioned above, the |compatible| string in this version has 
> changed compared to
> 
> the previously reviewed binding. Therefore, I believe it's a default 
> rule that the previous
> 
> |Reviewed-by|tags are no longer applicable. If the community requires a 
> note in the changelog to explain this,
> 
> I will make sure to include it in the next version.
> 
> 
> “
> 
> Did you read submitting patches?
> 
> ”
> 
> Yes, the explanations in the cover letter were written by me, so I have 
> definitely read them. All of these explanatory documents are
> 


Heh, why I am even reviewing this... you indicated in your address list
that you do not wish review from me, so I will keep that in mind and not
provide review.

Best regards,
Krzysztof