linux-kernel - Re: [PATCH 2/5] dt-bindings: remoteproc: qcom,sc8280xp-pas: Fix CDSP power desc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251105-dramatic-denim-kangaroo-cef9ed@kuoka>
Date: Wed, 5 Nov 2025 10:14:21 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Konrad Dybcio <konradybcio@...nel.org>
Cc: Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Bjorn Andersson <andersson@...nel.org>, Johan Hovold <johan+linaro@...nel.org>, 
	Mathieu Poirier <mathieu.poirier@...aro.org>, Manivannan Sadhasivam <mani@...nel.org>, 
	Vinod Koul <vkoul@...nel.org>, Michael Turquette <mturquette@...libre.com>, 
	Stephen Boyd <sboyd@...nel.org>, Taniya Das <quic_tdas@...cinc.com>, 
	Imran Shaik <quic_imrashai@...cinc.com>, Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>, 
	Jagadeesh Kona <quic_jkona@...cinc.com>, Ulf Hansson <ulf.hansson@...aro.org>, 
	Bryan O'Donoghue <bryan.odonoghue@...aro.org>, linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-remoteproc@...r.kernel.org, linux-clk@...r.kernel.org, 
	linux-pm@...r.kernel.org, Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Subject: Re: [PATCH 2/5] dt-bindings: remoteproc: qcom,sc8280xp-pas: Fix CDSP
 power desc

On Tue, Nov 04, 2025 at 08:31:07PM +0100, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
> 
> The power requirements for the CDSP instances on SC8280XP aren't fully
> described, with only one of the three present. Fix that.
> 
> Fixes: ee651cd1e944 ("dt-bindings: remoteproc: qcom: pas: Add sc8280xp adsp and nsp pair")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
> ---
>  Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml
> index 96d53baf6e00..5dbda3a55047 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml
> @@ -91,9 +91,13 @@ allOf:
>          power-domains:
>            items:
>              - description: NSP power domain
> +            - description: CX power domain
> +            - description: MXC power domain
>          power-domain-names:
>            items:
>              - const: nsp
> +            - const: cx
> +            - const: mxc

Heh, so if this was described since beginning entire binding would fit
100% into qcom,sm8550-pas.yaml, instead having this now in different
file because of different order. Not great. :(

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof