linux-kernel - Re: [PATCH 2/2] arm64: dts: qcom: hamoa: enable ETR and CTCU devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a1694c50-47a5-4f5c-abb1-6fec7a490e7a@kernel.org>
Date: Wed, 5 Nov 2025 10:17:35 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
 Jie Gan <jie.gan@....qualcomm.com>, Suzuki K Poulose
 <suzuki.poulose@....com>, Mike Leach <mike.leach@...aro.org>,
 James Clark <james.clark@...aro.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Tingwei Zhang <tingwei.zhang@....qualcomm.com>,
 Mao Jinlong <jinlong.mao@....qualcomm.com>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, coresight@...ts.linaro.org,
 linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: qcom: hamoa: enable ETR and CTCU devices

On 05/11/2025 10:09, Konrad Dybcio wrote:
> On 11/5/25 2:14 AM, Jie Gan wrote:
>>
>>
>> On 11/4/2025 8:47 PM, Konrad Dybcio wrote:
>>> On 11/4/25 9:10 AM, Jie Gan wrote:
>>>> Embedded Trace Router(ETR) is working as a DDR memory sink to collect
>>>> tracing data from source device.
>>>>
>>>> The CTCU serves as the control unit for the ETR device, managing its
>>>> behavior to determine how trace data is collected.
>>>>
>>>> Signed-off-by: Jie Gan <jie.gan@....qualcomm.com>
>>>> ---
>>>>   arch/arm64/boot/dts/qcom/hamoa.dtsi | 160 +++++++++++++++++++++++++++++++++++-
>>>>   1 file changed, 159 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/hamoa.dtsi b/arch/arm64/boot/dts/qcom/hamoa.dtsi
>>>> index a17900eacb20..ca4a473614ee 100644
>>>> --- a/arch/arm64/boot/dts/qcom/hamoa.dtsi
>>>> +++ b/arch/arm64/boot/dts/qcom/hamoa.dtsi
>>>> @@ -6713,6 +6713,35 @@ data-pins {
>>>>               };
>>>>           };
>>>>   +        ctcu@...01000 {
>>>> +            compatible = "qcom,hamoa-ctcu","qcom,sa8775p-ctcu";
>>>
>>> Missing space between after the comma
>>>
>>> no issues otherwise
>>
>> sorry for the mistake. Do I need send a new version to fix it?
> 
> I think you do since Krzysztof made some comments


Not a technical ones, but about the process.

Best regards,
Krzysztof