linux-kernel - Re: linux-next: new objtool warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251105100014.GY4068168@noisy.programming.kicks-ass.net>
Date: Wed, 5 Nov 2025 11:00:14 +0100
From: Peter Zijlstra <peterz@...radead.org>
To: Stephen Rothwell <sfr@...b.auug.org.au>
Cc: Josh Poimboeuf <jpoimboe@...nel.org>,
	Linux Next Mailing List <linux-next@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: new objtool warnings

On Wed, Nov 05, 2025 at 09:56:37AM +0100, Peter Zijlstra wrote:
> On Wed, Nov 05, 2025 at 02:30:27PM +1100, Stephen Rothwell wrote:
> 
> > These objtool messages have returned today.  No change in compiler.
> 
> Yes, Ingo also reported them on IRC, let me go investigate!

The below cures things, but I'm not quite sure why they show up now and
not before. Let me poke more.

---
diff --git a/include/linux/irq-entry-common.h b/include/linux/irq-entry-common.h
index 72e3f7a59469..6ab913e57da0 100644
--- a/include/linux/irq-entry-common.h
+++ b/include/linux/irq-entry-common.h
@@ -293,11 +293,11 @@ static __always_inline void irqentry_exit_to_user_mode_prepare(struct pt_regs *r
 static __always_inline void exit_to_user_mode(void)
 {
 	instrumentation_begin();
+	unwind_reset_info();
 	trace_hardirqs_on_prepare();
 	lockdep_hardirqs_on_prepare();
 	instrumentation_end();
 
-	unwind_reset_info();
 	user_enter_irqoff();
 	arch_exit_to_user_mode();
 	lockdep_hardirqs_on(CALLER_ADDR0);