linux-kernel - Re: (subset) [PATCH v5 0/2] driver: reset: spacemit-p1: add driver for poweroff/reboot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251105100856.GG8064@google.com>
Date: Wed, 5 Nov 2025 10:08:56 +0000
From: Lee Jones <lee@...nel.org>
To: Troy Mitchell <troy.mitchell@...ux.spacemit.com>
Cc: Sebastian Reichel <sebastian.reichel@...labora.com>,
	linux-kernel@...r.kernel.org, Sebastian Reichel <sre@...nel.org>,
	Yixun Lan <dlan@...too.org>, Paul Walmsley <pjw@...nel.org>,
	Palmer Dabbelt <palmer@...belt.com>,
	Albert Ou <aou@...s.berkeley.edu>, Alexandre Ghiti <alex@...ti.fr>,
	linux-riscv@...ts.infradead.org, spacemit@...ts.linux.dev,
	Aurelien Jarno <aurelien@...el32.net>, linux-pm@...r.kernel.org
Subject: Re: (subset) [PATCH v5 0/2] driver: reset: spacemit-p1: add driver
 for poweroff/reboot

On Wed, 05 Nov 2025, Troy Mitchell wrote:

> On Wed, Nov 05, 2025 at 09:34:21AM +0000, Lee Jones wrote:
> > On Tue, 04 Nov 2025, Troy Mitchell wrote:
> > 
> > > On Mon, Nov 03, 2025 at 01:48:33AM +0100, Sebastian Reichel wrote:
> > > > 
> > > > On Mon, 03 Nov 2025 00:01:58 +0100, Aurelien Jarno wrote:
> > > > > This adds poweroff/reboot support for the SpacemiT P1 PMIC chip, which is
> > > > > commonly paired with the SpacemiT K1 SoC.
> > > > > 
> > > > > Note: For reliable operation, this driver depends on a this patch that adds
> > > > > atomic transfer support to the SpacemiT I2C controller driver:
> > > > >   https://lore.kernel.org/spacemit/20251009-k1-i2c-atomic-v4-1-a89367870286@linux.spacemit.com/
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> dependency is here.
> > > > > 
> > > > > [...]
> > > > 
> > > > Applied, thanks!
> > > > 
> > > > [1/2] driver: reset: spacemit-p1: add driver for poweroff/reboot
> > > >       commit: 28124cc0fb8c7dc01a6834d227351e25d9a92c58
> > > Should we apply it now? The dependency patch hasn’t been merged yet...
> > 
> > What is the dependency?
> I point it out above.
> Without this patch, reboot and shutdown would end up calling the non-atomic i2c_transfer.

Okay, thanks.  I was mostly checking that you weren't referring to the
MFD patch, which doesn't represent a true dependency.

-- 
Lee Jones [李琼斯]