linux-kernel - Re: [RFC PATCH 05/56] x86/bugs: Reset spectre

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251105110318.GAaQsu9vGkzSxGbzzx@fat_crate.local>
Date: Wed, 5 Nov 2025 12:03:18 +0100
From: Borislav Petkov <bp@...en8.de>
To: Josh Poimboeuf <jpoimboe@...nel.org>
Cc: "Kaplan, David" <David.Kaplan@....com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <peterz@...radead.org>,
	Pawan Gupta <pawan.kumar.gupta@...ux.intel.com>,
	Ingo Molnar <mingo@...hat.com>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	"x86@...nel.org" <x86@...nel.org>,
	"H . Peter Anvin" <hpa@...or.com>, Alexander Graf <graf@...zon.com>,
	Boris Ostrovsky <boris.ostrovsky@...cle.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH 05/56] x86/bugs: Reset spectre_v2 mitigations

On Tue, Nov 04, 2025 at 06:29:20PM -0800, Josh Poimboeuf wrote:
> Separate functions allows each reset function to stay close to its
> select/update/apply counterparts.  That makes it easier to tell that
> it's undoing all the right things.  Plus it preserves the existing
> logical code layout/separation between mitigations.

... with a forward declaration for each one? Because we don't have enough
functions in this file already? And even if the code structure is begging for
us to turn it a OOO design, we're not doing it?

Sorry, but one big function with comments is at least keeping it saner. And
I'm sure your favourite editor can help you jump back'n'forth easily. :-P

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette