linux-kernel - Re: [PATCH 1/1] checkpatch: Deprecate container_of() in favour of container_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aQtKul7TSt-UVsIl@infradead.org>
Date: Wed, 5 Nov 2025 05:01:46 -0800
From: Christoph Hellwig <hch@...radead.org>
To: Sakari Ailus <sakari.ailus@....fi>
Cc: Joe Perches <joe@...ches.com>,
	Sakari Ailus <sakari.ailus@...ux.intel.com>,
	Andy Whitcroft <apw@...onical.com>, linux-kernel@...r.kernel.org,
	Dwaipayan Ray <dwaipayanray1@...il.com>,
	Lukas Bulwahn <lukas.bulwahn@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 1/1] checkpatch: Deprecate container_of() in favour of
 container_of_const()

Well, if container_of_const is a drop-in replacement for all uses of
container_of, just fix the implementation?  If it is an almost but not
complete replacement, find a different name for the few uses.  And if
it's not anywhere near drop in, just using container_of make a lot more
sense.

Just in case it wasn't clear:  We really should keep the shorter nice
name as the default if at all possible.  Both because it reads better
and because it avoids churn.