linux-kernel - Re: [PATCH v2] scripts: coccicheck: filter *.cocci files by MODE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <88daba74-f005-4be7-be3b-627ccd424276@oss.qualcomm.com>
Date: Wed, 5 Nov 2025 09:53:06 +0800
From: Songwei Chai <songwei.chai@....qualcomm.com>
To: Nicolas Palix <nicolas.palix@...g.fr>,
        Julia Lawall <Julia.Lawall@...ia.fr>, cocci@...ia.fr
Cc: linux-kernel@...r.kernel.org,
        Tingwei Zhang <tingwei.zhang@....qualcomm.com>,
        jinlong.mao@....qualcomm.com
Subject: Re: [PATCH v2] scripts: coccicheck: filter *.cocci files by MODE

Gentle Reminder.

On 10/27/2025 10:39 AM, Songwei Chai wrote:
> Hi Nicolas/Julia,
>
> Noticed this patch has stalled after being ACKed.
>
> Could you please help review it and assist in pushing it forward for 
> merging?
>
> Thanks.
>
> On 6/6/2025 3:26 PM, Nicolas Palix wrote:
>> Le 06/06/2025 à 08:09, Songwei Chai a écrit :
>>> Enhance the coccicheck script to filter *.cocci files based on the
>>> specified MODE (e.g., report, patch). This ensures that only compatible
>>> semantic patch files are executed, preventing errors such as:
>>>
>>>      "virtual rule report not supported"
>>>
>>> This error occurs when a .cocci file does not define a 'virtual <MODE>'
>>> rule, yet is executed in that mode.
>>>
>>> For example:
>>>
>>>      make coccicheck M=drivers/hwtracing/coresight/ MODE=report
>>>
>>> In this case, running "secs_to_jiffies.cocci" would trigger the error
>>> because it lacks support for 'report' mode. With this change, such 
>>> files
>>> are skipped automatically, improving robustness and developer
>>> experience.
>>>
>>> Signed-off-by: Songwei Chai <quic_songchai@...cinc.com>
>> Acked-by: Nicolas Palix <nicolas.palix@...g.fr>
>>> ---
>>>   scripts/coccicheck | 6 +++++-
>>>   1 file changed, 5 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/scripts/coccicheck b/scripts/coccicheck
>>> index 0e6bc5a10320..89d591af5f3e 100755
>>> --- a/scripts/coccicheck
>>> +++ b/scripts/coccicheck
>>> @@ -270,7 +270,11 @@ fi
>>>     if [ "$COCCI" = "" ] ; then
>>>       for f in `find $srctree/scripts/coccinelle/ -name '*.cocci' 
>>> -type f | sort`; do
>>> -    coccinelle $f
>>> +        if grep -q "virtual[[:space:]]\+$MODE" "$f"; then
>>> +                coccinelle $f
>>> +        else
>>> +                echo "warning: Skipping $f as it does not match 
>>> mode '$MODE'"
>>> +        fi
>>>       done
>>>   else
>>>       coccinelle $COCCI
>>>
>>