linux-kernel - Re: [PATCH 0/4] fpga: Add dummy definitions of API functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aQtabTZ16CN1pmMl@yilunxu-OptiPlex-7050>
Date: Wed, 5 Nov 2025 22:08:45 +0800
From: Xu Yilun <yilun.xu@...ux.intel.com>
To: Ian Abbott <abbotti@....co.uk>
Cc: linux-fpga@...r.kernel.org, Moritz Fischer <mdf@...nel.org>,
	Xu Yilun <yilun.xu@...el.com>, Tom Rix <trix@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/4] fpga: Add dummy definitions of API functions

On Wed, Nov 05, 2025 at 10:37:39AM +0000, Ian Abbott wrote:
> On 2025-11-05 01:47, Xu Yilun wrote:
> > On Tue, Nov 04, 2025 at 03:27:01PM +0000, Ian Abbott wrote:
> > > Add dummy definitions of the FPGA API functions for build testing
> > > 
> > > 1) fpga: altera-pr-ip: Add dummy definitions of API functions
> > > 2) fpga: bridge: Add dummy definitions of API functions
> > > 3) fpga: manager: Add dummy definitions of API functions
> > > 4) fpga: region: Add dummy definitions of API functions
> > 
> > Sorry I don't get the idea. Why should someone use FPGA APIs without
> > selecting CONIG_FPGA_XXX? Better make the changes along with the use
> > case patches.
> 
> Projects using FPGAs often have custom devices with custom, out-of-tree
> drivers, so it's quite useful to be able to build test those drivers against
> later kernel versions on the host to keep up with kernel API drift, prior to

But why don't you select the FPGA options on your "later kernel"? I
don't see much benifit for not doing so. Finally you still need
runtime test for new kernel adoption which requires selecting these
FPGA options.

And the problem for these stubs is, real users lose the chance to find
config error at earlier stage.

> possible later adoption of the kernel version on the target.
> 
> > Thanks,
> > Yilun
> > 
> > > 
> > >   include/linux/fpga/altera-pr-ip-core.h |  8 ++-
> > >   include/linux/fpga/fpga-bridge.h       | 75 ++++++++++++++++++++++++++-
> > >   include/linux/fpga/fpga-mgr.h          | 95 +++++++++++++++++++++++++++++++---
> > >   include/linux/fpga/fpga-region.h       | 44 ++++++++++++++--
> > >   4 files changed, 207 insertions(+), 15 deletions(-)
> However, I messed up the patches, because I only built them without the FPGA
> configure options defined.  I plan to submit a v2 patch series unless it is
> deemed a complete waste of effort by the maintainers.

Sorry, for now it still seems unnecessary to me.

Thanks,
Yilun

> 
> Cheers,
> Ian
> -- 
> -=( Ian Abbott <abbotti@....co.uk> || MEV Ltd. is a company  )=-
> -=( registered in England & Wales.  Regd. number: 02862268.  )=-
> -=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
> -=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-
>