linux-kernel - RE: [PATCH v3] EDAC/ie31200: Fix error handling in ie31200_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CY8PR11MB7134D38563B5485D2426CBE989C2A@CY8PR11MB7134.namprd11.prod.outlook.com>
Date: Thu, 6 Nov 2025 13:07:37 +0000
From: "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>
To: Ma Ke <make24@...as.ac.cn>, "jbaron@...mai.com" <jbaron@...mai.com>,
	"bp@...en8.de" <bp@...en8.de>, "Luck, Tony" <tony.luck@...el.com>
CC: "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>
Subject: RE: [PATCH v3] EDAC/ie31200: Fix error handling in
 ie31200_register_mci

> From: Ma Ke <make24@...as.ac.cn>
> Sent: Thursday, November 6, 2025 4:48 PM
> To: jbaron@...mai.com; bp@...en8.de; Luck, Tony <tony.luck@...el.com>;
> Zhuo, Qiuxu <qiuxu.zhuo@...el.com>
> Cc: linux-edac@...r.kernel.org; linux-kernel@...r.kernel.org; akpm@...ux-
> foundation.org; Ma Ke <make24@...as.ac.cn>
> Subject: [PATCH v3] EDAC/ie31200: Fix error handling in ie31200_register_mci
> 
> ie31200_register_mci() calls device_initialize() for priv->dev unconditionally.
> However, in the error path, put_device() is not called, leading to an
> imbalance. Similarly, in the unload path,
> put_device() is missing.
> 
> Although edac_mc_free() eventually frees the memory, it does not release the
> device initialized by device_initialize(). For code readability and proper pairing
> of device_initialize()/put_device(), add put_device() calls in both error and
> unload paths.
> 
> Found by code review.
> 
> Signed-off-by: Ma Ke <make24@...as.ac.cn>
> ---
> Changes in v3:
> - moved put_device() from fail_free to fail_unmap to avoid using uninitialized
> priv variable when window allocation fails.

Oops ... I didn't catch that during v2 review. 

For v3:
Reviewed-by: Qiuxu Zhuo <qiuxu.zhuo@...el.com>

> [...]