linux-kernel - Re: [PATCH net v1 1/2] page_pool: expose max page pool ring size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAC_iWjK1bz9a_SzYsEuZmqvYDWT6h6hFwWdX2OO5aNBcjp1MFw@mail.gmail.com>
Date: Thu, 6 Nov 2025 15:12:30 +0200
From: Ilias Apalodimas <ilias.apalodimas@...aro.org>
To: Mina Almasry <almasrymina@...gle.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Joshua Washington <joshwash@...gle.com>, Harshitha Ramamurthy <hramamurthy@...gle.com>, 
	Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Jesper Dangaard Brouer <hawk@...nel.org>, Simon Horman <horms@...nel.org>, 
	Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH net v1 1/2] page_pool: expose max page pool ring size

On Wed, 5 Nov 2025 at 22:08, Mina Almasry <almasrymina@...gle.com> wrote:
>
> Expose this as a constant so we can reuse it in drivers.
>
> Signed-off-by: Mina Almasry <almasrymina@...gle.com>
> ---
>  include/net/page_pool/types.h | 2 ++
>  net/core/page_pool.c          | 2 +-
>  2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/include/net/page_pool/types.h b/include/net/page_pool/types.h
> index 1509a536cb85..5edba3122b10 100644
> --- a/include/net/page_pool/types.h
> +++ b/include/net/page_pool/types.h
> @@ -58,6 +58,8 @@ struct pp_alloc_cache {
>         netmem_ref cache[PP_ALLOC_CACHE_SIZE];
>  };
>
> +#define PAGE_POOL_MAX_RING_SIZE 16384
> +
>  /**
>   * struct page_pool_params - page pool parameters
>   * @fast:      params accessed frequently on hotpath
> diff --git a/net/core/page_pool.c b/net/core/page_pool.c
> index 1a5edec485f1..7b2808da294f 100644
> --- a/net/core/page_pool.c
> +++ b/net/core/page_pool.c
> @@ -211,7 +211,7 @@ static int page_pool_init(struct page_pool *pool,
>                 return -EINVAL;
>
>         if (pool->p.pool_size)
> -               ring_qsize = min(pool->p.pool_size, 16384);
> +               ring_qsize = min(pool->p.pool_size, PAGE_POOL_MAX_RING_SIZE);
>
>         /* DMA direction is either DMA_FROM_DEVICE or DMA_BIDIRECTIONAL.
>          * DMA_BIDIRECTIONAL is for allowing page used for DMA sending,
>
> base-commit: 327c20c21d80e0d87834b392d83ae73c955ad8ff
> --
> 2.51.2.1026.g39e6a42477-goog
>

Reviewed-by: Ilias Apalodimas <ilias.apalodimas@...aro.org>