linux-kernel - Re: [PATCH net] net/mlx5e: Fix return value in case of module EEPROM read error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <176239381424.3828781.3734885280355871994.git-patchwork-notify@kernel.org>
Date: Thu, 06 Nov 2025 01:50:14 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Tariq Toukan <tariqt@...dia.com>
Cc: edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
 andrew+netdev@...n.ch, davem@...emloft.net, saeedm@...dia.com,
 mbloch@...dia.com, leon@...nel.org, netdev@...r.kernel.org,
 linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org, gal@...dia.com,
 alazar@...dia.com
Subject: Re: [PATCH net] net/mlx5e: Fix return value in case of module EEPROM
 read
 error

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Tue, 4 Nov 2025 16:15:36 +0200 you wrote:
> From: Gal Pressman <gal@...dia.com>
> 
> mlx5e_get_module_eeprom_by_page() has weird error handling.
> 
> First, it is treating -EINVAL as a special case, but it is unclear why.
> 
> Second, it tries to fail "gracefully" by returning the number of bytes
> read even in case of an error. This results in wrongly returning
> success (0 return value) if the error occurs before any bytes were
> read.
> 
> [...]

Here is the summary with links:
  - [net] net/mlx5e: Fix return value in case of module EEPROM read error
    https://git.kernel.org/netdev/net/c/d1c94bc5b90c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html