linux-kernel - Re: [PATCH v1] mfd: max77705: support revision 0x2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251106134155.GM8064@google.com>
Date: Thu, 6 Nov 2025 13:41:55 +0000
From: Lee Jones <lee@...nel.org>
To: Eric Gonçalves <ghatto404@...il.com>
Cc: Krzysztof Kozlowski <krzk@...nel.org>,
	Chanwoo Choi <cw00.choi@...sung.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] mfd: max77705: support revision 0x2

On Thu, 23 Oct 2025, Eric Gonçalves wrote:

> 
> 
> On October 23, 2025 11:21:44 AM GMT-03:00, Lee Jones <lee@...nel.org> wrote:
> >On Thu, 23 Oct 2025, Ghatto wrote:
> >
> >> On Thu, Oct 23, 2025 at 10:17 AM Lee Jones <lee@...nel.org> wrote:
> >> >
> >> > On Tue, 14 Oct 2025, Eric Gonçalves wrote:
> >> >
> >> > > Revision 0x2 has been tested on the r0q (Galaxy S22) board.
> >> > >
> >> > > Signed-off-by: Eric Gonçalves <ghatto404@...il.com>
> >> > > ---
> >> > >  drivers/mfd/max77705.c | 4 ++--
> >> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> >> > >
> >> > > diff --git a/drivers/mfd/max77705.c b/drivers/mfd/max77705.c
> >> > > index e1a9bfd65856..5201a4c9c3f5 100644
> >> > > --- a/drivers/mfd/max77705.c
> >> > > +++ b/drivers/mfd/max77705.c
> >> > > @@ -105,8 +105,8 @@ static int max77705_i2c_probe(struct i2c_client *i2c)
> >> > >               return -ENODEV;
> >> > >
> >> > >       pmic_rev = pmic_rev_value & MAX77705_REVISION_MASK;
> >> > > -     if (pmic_rev != MAX77705_PASS3)
> >> > > -             return dev_err_probe(dev, -ENODEV, "Rev.0x%x is not tested\n", pmic_rev);
> >> > > +     if (pmic_rev == MAX77705_PASS1)
> >> > > +             return dev_err_probe(dev, -ENODEV, "Rev.0x1 is not tested\n");
> >> >
> >> > What happens when PASS4 is released but not tested?
> >> PASS4 doesn't exist from what I've seen on the max77705 header files.
> >
> >Not yet.
> >
> >But not having it in the defined does not mean one won't exist in the future.
> I don't think it will, newer Samsungs already use a new maxim controller.

Stranger things have happened.  Let's take the 'better to be safe than
sorry' approach and future-proof this the best we can.  Let's do a
proper bounds check for supported devices instead please.

-- 
Lee Jones [李琼斯]