linux-kernel - Re: [PATCH v5 3/8] media: mediatek: vcodec: add profile and level supporting for MT8189

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8408b589db4c31e32dafb6cf7c80a80c94b488c7.camel@collabora.com>
Date: Thu, 06 Nov 2025 09:23:32 -0500
From: Nicolas Dufresne <nicolas.dufresne@...labora.com>
To: Kyrie Wu <kyrie.wu@...iatek.com>, Tiffany Lin
 <tiffany.lin@...iatek.com>,  Andrew-CT Chen <andrew-ct.chen@...iatek.com>,
 Yunfei Dong <yunfei.dong@...iatek.com>, Mauro Carvalho Chehab	
 <mchehab@...nel.org>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski	
 <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Matthias Brugger	
 <matthias.bgg@...il.com>, AngeloGioacchino Del Regno	
 <angelogioacchino.delregno@...labora.com>, Hans Verkuil
 <hverkuil@...all.nl>,  Nathan Hebert <nhebert@...omium.org>, Arnd Bergmann
 <arnd@...db.de>, Irui Wang <irui.wang@...iatek.com>,  George Sun
 <george.sun@...iatek.com>, linux-media@...r.kernel.org,
 devicetree@...r.kernel.org, 	linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, 	linux-mediatek@...ts.infradead.org,
 Yilong Zhou <yilong.zhou@...iatek.com>
Cc: Neil Armstrong <neil.armstrong@...aro.org>, Andrzej Pietrasiewicz
	 <andrzejtp2010@...il.com>
Subject: Re: [PATCH v5 3/8] media: mediatek: vcodec: add profile and level
 supporting for MT8189

Hi,

Le jeudi 06 novembre 2025 à 14:13 +0800, Kyrie Wu a écrit :
> add profile and level supporting for H264 and vp9 of MT8189
> 
> Signed-off-by: Kyrie Wu <kyrie.wu@...iatek.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> ---
>  .../mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c        | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c
> index c1cef78471a9..0a9bdc5316f9 100644
> --- a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c
> +++ b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c
> @@ -552,6 +552,7 @@ static void mtk_vcodec_dec_fill_h264_level(struct v4l2_ctrl_config *cfg,
>  	switch (ctx->dev->chip_name) {
>  	case MTK_VDEC_MT8192:
>  	case MTK_VDEC_MT8188:
> +	case MTK_VDEC_MT8189:
>  		cfg->max = V4L2_MPEG_VIDEO_H264_LEVEL_5_2;

Please consider my suggestion in 2/8, you could then move all of this into the
static compatible data structure.

Nicolas

>  		break;
>  	case MTK_VDEC_MT8195:
> @@ -573,6 +574,7 @@ static void mtk_vcodec_dec_fill_h264_profile(struct v4l2_ctrl_config *cfg,
>  {
>  	switch (ctx->dev->chip_name) {
>  	case MTK_VDEC_MT8188:
> +	case MTK_VDEC_MT8189:
>  	case MTK_VDEC_MT8195:
>  	case MTK_VDEC_MT8196:
>  		cfg->max = V4L2_MPEG_VIDEO_H264_PROFILE_HIGH_10;
> @@ -623,6 +625,7 @@ static void mtk_vcodec_dec_fill_vp9_level(struct v4l2_ctrl_config *cfg,
>  	case MTK_VDEC_MT8188:
>  		cfg->max = V4L2_MPEG_VIDEO_VP9_LEVEL_5_1;
>  		break;
> +	case MTK_VDEC_MT8189:
>  	case MTK_VDEC_MT8195:
>  	case MTK_VDEC_MT8196:
>  		cfg->max = V4L2_MPEG_VIDEO_VP9_LEVEL_5_2;
> @@ -641,6 +644,7 @@ static void mtk_vcodec_dec_fill_vp9_profile(struct v4l2_ctrl_config *cfg,
>  {
>  	switch (ctx->dev->chip_name) {
>  	case MTK_VDEC_MT8188:
> +	case MTK_VDEC_MT8189:
>  	case MTK_VDEC_MT8195:
>  	case MTK_VDEC_MT8196:
>  		cfg->max = V4L2_MPEG_VIDEO_VP9_PROFILE_2;

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)