linux-kernel - Re: [PATCH net-next v7 12/12] net: dsa: add driver for MaxLinear GSW1xx switch family

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <df47ae11-5f54-4870-bea8-8392a7fa47de@redhat.com>
Date: Thu, 6 Nov 2025 15:38:04 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: "Sverdlin, Alexander" <alexander.sverdlin@...mens.com>,
 "daniel@...rotopia.org" <daniel@...rotopia.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc: "andrew@...n.ch" <andrew@...n.ch>, "olteanv@...il.com"
 <olteanv@...il.com>, "robh@...nel.org" <robh@...nel.org>,
 "lxu@...linear.com" <lxu@...linear.com>, "john@...ozen.org"
 <john@...ozen.org>, "davem@...emloft.net" <davem@...emloft.net>,
 "yweng@...linear.com" <yweng@...linear.com>,
 "bxu@...linear.com" <bxu@...linear.com>,
 "edumazet@...gle.com" <edumazet@...gle.com>,
 "conor+dt@...nel.org" <conor+dt@...nel.org>,
 "fchan@...linear.com" <fchan@...linear.com>,
 "ajayaraman@...linear.com" <ajayaraman@...linear.com>,
 "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
 "hauke@...ke-m.de" <hauke@...ke-m.de>, "horms@...nel.org"
 <horms@...nel.org>, "kuba@...nel.org" <kuba@...nel.org>,
 "jpovazanec@...linear.com" <jpovazanec@...linear.com>,
 "linux@...linux.org.uk" <linux@...linux.org.uk>
Subject: Re: [PATCH net-next v7 12/12] net: dsa: add driver for MaxLinear
 GSW1xx switch family

On 11/4/25 9:03 AM, Sverdlin, Alexander wrote:
> On Mon, 2025-11-03 at 12:20 +0000, Daniel Golle wrote:
>> Add driver for the MaxLinear GSW1xx family of Ethernet switch ICs which
>> are based on the same IP as the Lantiq/Intel GSWIP found in the Lantiq VR9
>> and Intel GRX MIPS router SoCs. The main difference is that instead of
>> using memory-mapped I/O to communicate with the host CPU these ICs are
>> connected via MDIO (or SPI, which isn't supported by this driver).
>> Implement the regmap API to access the switch registers over MDIO to allow
>> reusing lantiq_gswip_common for all core functionality.
>>
>> The GSW1xx also comes with a SerDes port capable of 1000Base-X, SGMII and
>> 2500Base-X, which can either be used to connect an external PHY or SFP
>> cage, or as the CPU port. Support for the SerDes interface is implemented
>> in this driver using the phylink_pcs interface.
>>
>> Signed-off-by: Daniel Golle <daniel@...rotopia.org>
> 
> thank you for the patch!
> 
> Finally I was able to run selftest/drivers/net/dsa/local_termination.sh
> with only 2 unexpected failures on a GSW145 hardware (with TI AM62
> host CPU and its CPSW (not in switchdev mode) as CPU interface).
> 
> The problems I had in the past were neither related to the GSW145 code,
> nor to am65-cpsw-nuss, but to the test itself:
> https://lore.kernel.org/all/20251104061723.483301-1-alexander.sverdlin@siemens.com/
> 
> The remaining failing test cases are:
> TEST: VLAN over vlan_filtering=1 bridged port: Unicast IPv4 to unknown MAC address   [FAIL]
>         reception succeeded, but should have failed
> TEST: VLAN over vlan_filtering=1 bridged port: Unicast IPv4 to unknown MAC address, allmulti   [FAIL]
>         reception succeeded, but should have failed
> 
> So far I didn't notice any problems with untagged read-word IP traffic over
> GSW145 ports.
> 
> Do you have a suggestion what could I check further regarding the failing
> test cases? As I understood, all of them pass on your side?

Could be that due to different revisions of the relevant H/W?

I tend to think we are better off merging the series as-is, and handle
the above with follow-up, as needed. Any different opinions?

Thanks,

Paolo