linux-kernel - Re: [PATCH] selftests: net: local_termination: Wait for interfaces to come up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8d9c37d0-b238-4778-b18c-473bddd6481c@redhat.com>
Date: Thu, 6 Nov 2025 15:53:09 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Vladimir Oltean <vladimir.oltean@....com>,
 "A. Sverdlin" <alexander.sverdlin@...mens.com>
Cc: netdev@...r.kernel.org, linux-kselftest@...r.kernel.org,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Simon Horman <horms@...nel.org>,
 Shuah Khan <shuah@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftests: net: local_termination: Wait for interfaces to
 come up

On 11/5/25 10:31 PM, Vladimir Oltean wrote:
> Functionally I have nothing against this change.
> 
> Reviewed-by: Vladimir Oltean <vladimir.oltean@....com>
> 
> Two ideas to minimize the delta in a more obviously correct way.
> They can perhaps be implemented together, independently of one another,
> or not at all:
> 
> - setup_wait() could be used directly, as it waits for $NUM_NETIFS, aka
>   $h1 and $h2.
> - There is no case where run_test() does not need a prior setup_wait()
>   call, so it can just as well be placed as the first thing of that
>   function.

I think both suggestions make a lot of sense, @Alexander: please send
and updated version including them. You can retain Vladimir's RB tag.

Thanks,

Paolo