linux-kernel - Re: [PATCH v5 2/7] rust: devres: style for imports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251106171021.3e724b36.zhiw@nvidia.com>
Date: Thu, 6 Nov 2025 17:10:26 +0200
From: Zhi Wang <zhiw@...dia.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
CC: <rust-for-linux@...r.kernel.org>, <linux-pci@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <dakr@...nel.org>, <aliceryhl@...gle.com>,
	<bhelgaas@...gle.com>, <kwilczynski@...nel.org>, <ojeda@...nel.org>,
	<alex.gaynor@...il.com>, <boqun.feng@...il.com>, <gary@...yguo.net>,
	<bjorn3_gh@...tonmail.com>, <lossin@...nel.org>, <a.hindborg@...nel.org>,
	<tmgross@...ch.edu>, <markus.probst@...teo.de>, <helgaas@...nel.org>,
	<cjia@...dia.com>, <smitra@...dia.com>, <ankita@...dia.com>,
	<aniketa@...dia.com>, <kwankhede@...dia.com>, <targupta@...dia.com>,
	<acourbot@...dia.com>, <joelagnelf@...dia.com>, <jhubbard@...dia.com>,
	<zhiwang@...nel.org>
Subject: Re: [PATCH v5 2/7] rust: devres: style for imports

On Thu, 6 Nov 2025 14:34:25 +0100
Miguel Ojeda <miguel.ojeda.sandonis@...il.com> wrote:

> On Thu, Nov 6, 2025 at 11:28 AM Zhi Wang <zhiw@...dia.com> wrote:
> >
> > +///     device::{Bound, Device},
> 
> Is this one converted?
> 
> > +    /// # use kernel::{
> > +    ///     device::Core,
> 
> This hides only the first line, which will look quite confusing when
> rendered -- please double-check with the `rustdoc` target.
> 

Thanks for the pointer. Let me take a look and fix it in the next
re-spin.

> Thanks!
> 
> Cheers,
> Miguel