linux-kernel - Re: [PATCH v6 2/2] usb: typec: hd3ss3220: Enable VBUS based on ID pin state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <65a910ff-61ae-41a8-b5aa-9a7a119fb13d@oss.qualcomm.com>
Date: Thu, 6 Nov 2025 20:53:44 +0530
From: Krishna Kurapati PSSNV <krishna.kurapati@....qualcomm.com>
To: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Biju Das <biju.das.jz@...renesas.com>,
        Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>,
        linux-usb@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 2/2] usb: typec: hd3ss3220: Enable VBUS based on ID pin
 state



On 11/6/2025 3:46 PM, Heikki Krogerus wrote:
>>          struct regulator *vbus;
>>
>>          vbus = devm_of_regulator_get_optional(...
>>          if (IS_ERR(vbus) && vbus != ERR_PTR(-ENODEV))
>>                  return PTR_ERR(vbus);
>>
>>          hd3ss3220->vbus = vbus;
> 
> Sorry, that has to be:
> 
>          hd3ss3220->vbus = vbus == ERR_PTR(-ENODEV) ? NULL : vbus;
> 
> 

Thanks for the review Heikki.
Will update the suggestions in next revision.

Regards,
Krishna,