linux-kernel - Re: [PATCH net-next v7 12/12] net: dsa: add driver for MaxLinear GSW1xx switch family

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251106153040.k7wnctqb6rcpafgs@skbuf>
Date: Thu, 6 Nov 2025 17:30:40 +0200
From: Vladimir Oltean <olteanv@...il.com>
To: Paolo Abeni <pabeni@...hat.com>
Cc: "Sverdlin, Alexander" <alexander.sverdlin@...mens.com>,
	"daniel@...rotopia.org" <daniel@...rotopia.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"andrew@...n.ch" <andrew@...n.ch>,
	"robh@...nel.org" <robh@...nel.org>,
	"lxu@...linear.com" <lxu@...linear.com>,
	"john@...ozen.org" <john@...ozen.org>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"yweng@...linear.com" <yweng@...linear.com>,
	"bxu@...linear.com" <bxu@...linear.com>,
	"edumazet@...gle.com" <edumazet@...gle.com>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>,
	"fchan@...linear.com" <fchan@...linear.com>,
	"ajayaraman@...linear.com" <ajayaraman@...linear.com>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	"hauke@...ke-m.de" <hauke@...ke-m.de>,
	"horms@...nel.org" <horms@...nel.org>,
	"kuba@...nel.org" <kuba@...nel.org>,
	"jpovazanec@...linear.com" <jpovazanec@...linear.com>,
	"linux@...linux.org.uk" <linux@...linux.org.uk>
Subject: Re: [PATCH net-next v7 12/12] net: dsa: add driver for MaxLinear
 GSW1xx switch family

On Thu, Nov 06, 2025 at 03:38:04PM +0100, Paolo Abeni wrote:
> On 11/4/25 9:03 AM, Sverdlin, Alexander wrote:
> > The problems I had in the past were neither related to the GSW145 code,
> > nor to am65-cpsw-nuss, but to the test itself:
> > https://lore.kernel.org/all/20251104061723.483301-1-alexander.sverdlin@siemens.com/
> > 
> > The remaining failing test cases are:
> > TEST: VLAN over vlan_filtering=1 bridged port: Unicast IPv4 to unknown MAC address   [FAIL]
> >         reception succeeded, but should have failed
> > TEST: VLAN over vlan_filtering=1 bridged port: Unicast IPv4 to unknown MAC address, allmulti   [FAIL]
> >         reception succeeded, but should have failed
> > 
> > So far I didn't notice any problems with untagged read-word IP traffic over
> > GSW145 ports.
> > 
> > Do you have a suggestion what could I check further regarding the failing
> > test cases? As I understood, all of them pass on your side?
> 
> Could be that due to different revisions of the relevant H/W?
> 
> I tend to think we are better off merging the series as-is, and handle
> the above with follow-up, as needed. Any different opinions?

Yeah, it's a problem with the test.

I too agree with merging as-is. I do have some nitpicks but they don't
require resending the 12-patch series.