linux-kernel - Re: [PATCH v1 1/1] compiler_types: Warn about unused static inline functions on second

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aQzGP8Z-mvSS9w7C@smile.fi.intel.com>
Date: Thu, 6 Nov 2025 18:01:03 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Nathan Chancellor <nathan@...nel.org>
Cc: linux-kernel@...r.kernel.org, llvm@...ts.linux.dev,
	Nick Desaulniers <nick.desaulniers+lkml@...il.com>,
	Bill Wendling <morbo@...gle.com>,
	Justin Stitt <justinstitt@...gle.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Dan Williams <dan.j.williams@...el.com>,
	Jonathan Cameron <jonathan.cameron@...wei.com>,
	Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH v1 1/1] compiler_types: Warn about unused static inline
 functions on second

On Thu, Nov 06, 2025 at 08:16:49AM -0700, Nathan Chancellor wrote:
> On Thu, Nov 06, 2025 at 11:50:00AM +0100, Andy Shevchenko wrote:

...

> >   * for W=1 build. This will allow clang to find unused functions. Remove the
> >   * __inline_maybe_unused entirely after fixing most of -Wunused-function warnings.

> The comment should be updated to W=2 instead of W=1

Granted.

> and we should
> probably drop the sentence about removing __inline_maybe_unused entirely
> since people such as Peter will never want this behavior by default. I
> do not mind doing it myself if I take it.

But future is uncertain, it might be that GCC also gains this and it won't
confuse anyway as it might become a truth (no more such warnings in the code)
at some point.

-- 
With Best Regards,
Andy Shevchenko