linux-kernel - Re: [PATCH v3 3/5] iio: test: Add kunit tests for iio_divide_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aQzIavXYD7fUbrqc@smile.fi.intel.com>
Date: Thu, 6 Nov 2025 18:10:18 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Romain Gantois <romain.gantois@...tlin.com>
Cc: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Jonathan Cameron <jic23@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Nuno Sá <nuno.sa@...log.com>,
	Andy Shevchenko <andy@...nel.org>, Hans de Goede <hansg@...nel.org>,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	linux-iio@...r.kernel.org
Subject: Re: [PATCH v3 3/5] iio: test: Add kunit tests for
 iio_divide_by_value()

On Thu, Nov 06, 2025 at 03:11:48PM +0100, Romain Gantois wrote:
> Add kunit tests for iio_divide_by_value(), these are similar to the
> existing tests for iio_multiply_value(), but the operand values used differ
> slightly.

When use abs() in the code, always add a check for the *_MIN.
This will give you a few surprises.

-- 
With Best Regards,
Andy Shevchenko