linux-kernel - Re: [PATCH v3] iio: imu: inv_icm45600: Initializes inv_icm45600_buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aQzJK0i5WBrk0VQf@smile.fi.intel.com>
Date: Thu, 6 Nov 2025 18:13:31 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: remi.buisson@....com
Cc: Jonathan Cameron <jic23@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Nuno Sá <nuno.sa@...log.com>,
	Andy Shevchenko <andy@...nel.org>,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>,
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] iio: imu: inv_icm45600: Initializes
 inv_icm45600_buffer_postdisable sleep

On Thu, Nov 06, 2025 at 03:31:07PM +0000, Remi Buisson via B4 Relay wrote:
> From: Remi Buisson <remi.buisson@....com>
> 
> The sleep variable in inv_icm45600_buffer_postdisable could be used without
> being assigned in case of error. It must be initialized to 0 by default.

> Closes:https://lore.kernel.org/linux-iio/aPi6Xw-ZoUkW76zR@stanley.mountain/

Missing space.

> 

Redundant blank line.

> Fixes: 06674a72cf7a ("iio: imu: inv_icm45600: add buffer support in iio devices")
> Signed-off-by: Remi Buisson <remi.buisson@....com>
> ---
> Changes in v3:
> - Fix commit message: fix and closes moved to SoB

Not really.

...

Code wise is good to me.

-- 
With Best Regards,
Andy Shevchenko