linux-kernel - Re: [PATCH] hid/hid-multitouch: Keep latency normal on deactivate for reactivation gesture

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s2pc7whgvrwaldkgkle4ydkyc26q75senkmtesv57du6x7bxoa@mq3ght3dksdr>
Date: Thu, 6 Nov 2025 17:50:13 +0100
From: Benjamin Tissoires <bentiss@...nel.org>
To: Werner Sembach <wse@...edocomputers.com>
Cc: Jiri Kosina <jikos@...nel.org>, linux-input@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hid/hid-multitouch: Keep latency normal on deactivate
 for reactivation gesture

On Nov 06 2025, Werner Sembach wrote:
> Uniwill devices have a built in gesture in the touchpad to de- and
> reactivate it by double taping the upper left corner. This gesture stops
> working when latency is set to high, so this patch keeps the latency on
> normal.
> 
> Signed-off-by: Werner Sembach <wse@...edocomputers.com>
> ---
> Or should I better implement this as a quirk?

Yeah, I guess a quirk would be appreciated. The high latency on close
was introduced on purpose for saving energy purpose. So this patch is
rather not nice for those systems where it matters.

Cheers,
Benjamin

> 
>  drivers/hid/hid-multitouch.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> index 179dc316b4b51..df64cb6c41699 100644
> --- a/drivers/hid/hid-multitouch.c
> +++ b/drivers/hid/hid-multitouch.c
> @@ -1998,7 +1998,7 @@ static void mt_on_hid_hw_open(struct hid_device *hdev)
>  
>  static void mt_on_hid_hw_close(struct hid_device *hdev)
>  {
> -	mt_set_modes(hdev, HID_LATENCY_HIGH, TOUCHPAD_REPORT_NONE);
> +	mt_set_modes(hdev, HID_LATENCY_NORMAL, TOUCHPAD_REPORT_NONE);
>  }
>  
>  /*
> -- 
> 2.43.0
>