linux-kernel - Re: [PATCH 2/4] vfio: selftests: Export vfio_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJHc60ztBSSm4SUxxeJ-YULhdYuCHSprtns0xt_WVJPvgmtsBA@mail.gmail.com>
Date: Thu, 6 Nov 2025 22:13:18 +0530
From: Raghavendra Rao Ananta <rananta@...gle.com>
To: David Matlack <dmatlack@...gle.com>
Cc: Alex Williamson <alex@...zbot.org>, Alex Williamson <alex.williamson@...hat.com>, 
	Josh Hilke <jrhilke@...gle.com>, kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] vfio: selftests: Export vfio_pci_device functions

On Thu, Nov 6, 2025 at 6:12 AM David Matlack <dmatlack@...gle.com> wrote:
>
> On 2025-11-04 12:35 AM, Raghavendra Rao Ananta wrote:
> > Refactor and make the functions called under device initialization
> > public. A later patch adds a test that calls these functions to validate
> > the UAPI of SR-IOV devices. Opportunistically, to test the success
> > and failure cases of the UAPI, split the functions dealing with
> > VFIO_GROUP_GET_DEVICE_FD and VFIO_DEVICE_BIND_IOMMUFD into a core
> > function and another one that asserts the ioctl. The former will be
> > used for testing the SR-IOV UAPI, hence only export these.
>
> I have a series that separates the IOMMU initialization and fields from
> struct vfio_pci_device. I suspect that will make what you are trying to
> do a lot easier.
>
> https://lore.kernel.org/kvm/20251008232531.1152035-1-dmatlack@google.com/
>
Nice! I'll take a look at it. By the way, how do we normally deal with
dependencies among series? Do we simply mention it in the
cover-letter?

> Can you take a look at it and see if it would simplifying things for
> you? Reviews would be very appreciated if so :)
Absolutely! Sorry, I have it on my TODO list to review the changes,
but didn't get a chance. I'll get to it soon. Thanks for the reminder
:)