linux-kernel - Re: [PATCH v10 2/2] Drivers: hv: Introduce mshv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c7e53740-ed96-470c-b16a-46061a9dfac7@linux.microsoft.com>
Date: Thu, 6 Nov 2025 22:33:06 +0530
From: Naman Jain <namjain@...ux.microsoft.com>
To: Michael Kelley <mhklinux@...look.com>,
 "K . Y . Srinivasan" <kys@...rosoft.com>,
 Haiyang Zhang <haiyangz@...rosoft.com>, Wei Liu <wei.liu@...nel.org>,
 Dexuan Cui <decui@...rosoft.com>, Thomas Gleixner <tglx@...utronix.de>,
 Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
 Dave Hansen <dave.hansen@...ux.intel.com>, "H . Peter Anvin" <hpa@...or.com>
Cc: "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "x86@...nel.org" <x86@...nel.org>, Peter Zijlstra <peterz@...radead.org>,
 Sean Christopherson <seanjc@...gle.com>, Paolo Bonzini
 <pbonzini@...hat.com>, Mukesh Rathor <mrathor@...ux.microsoft.com>,
 Stanislav Kinsburskii <skinsburskii@...ux.microsoft.com>,
 Nuno Das Neves <nunodasneves@...ux.microsoft.com>,
 Christoph Hellwig <hch@...radead.org>,
 Saurabh Sengar <ssengar@...ux.microsoft.com>,
 ALOK TIWARI <alok.a.tiwari@...cle.com>
Subject: Re: [PATCH v10 2/2] Drivers: hv: Introduce mshv_vtl driver

On 11/6/2025 8:24 PM, Michael Kelley wrote:
> From: Naman Jain <namjain@...ux.microsoft.com> Sent: Tuesday, October 28, 2025 10:02 PM
>>
>> Provide an interface for Virtual Machine Monitor like OpenVMM and its
>> use as OpenHCL paravisor to control VTL0 (Virtual trust Level).
>> Expose devices and support IOCTLs for features like VTL creation,
>> VTL0 memory management, context switch, making hypercalls,
>> mapping VTL0 address space to VTL2 userspace, getting new VMBus
>> messages and channel events in VTL2 etc.
>>
>> Co-developed-by: Roman Kisel <romank@...ux.microsoft.com>
>> Signed-off-by: Roman Kisel <romank@...ux.microsoft.com>
>> Co-developed-by: Saurabh Sengar <ssengar@...ux.microsoft.com>
>> Signed-off-by: Saurabh Sengar <ssengar@...ux.microsoft.com>
>> Signed-off-by: Naman Jain <namjain@...ux.microsoft.com>
>> ---
>>   arch/x86/hyperv/Makefile           |   10 +-
>>   arch/x86/hyperv/hv_vtl.c           |   43 +
>>   arch/x86/hyperv/mshv-asm-offsets.c |   37 +
>>   arch/x86/hyperv/mshv_vtl_asm.S     |   98 ++
>>   arch/x86/include/asm/mshyperv.h    |   34 +
>>   drivers/hv/Kconfig                 |   26 +-
>>   drivers/hv/Makefile                |    7 +-
>>   drivers/hv/mshv_vtl.h              |   25 +
>>   drivers/hv/mshv_vtl_main.c         | 1392 ++++++++++++++++++++++++++++
>>   include/hyperv/hvgdk_mini.h        |  106 +++
>>   include/uapi/linux/mshv.h          |   80 ++
>>   11 files changed, 1855 insertions(+), 3 deletions(-)
>>   create mode 100644 arch/x86/hyperv/mshv-asm-offsets.c
>>   create mode 100644 arch/x86/hyperv/mshv_vtl_asm.S
>>   create mode 100644 drivers/hv/mshv_vtl.h
>>   create mode 100644 drivers/hv/mshv_vtl_main.c
>>
> 
> I've reviewed and made suggestions on most of this code pretty
> carefully over the past few months and through 10 revisions. This
> version addresses my suggestions and looks good to me. There
> are a few areas, such as the assembly code in mshv_vtl_asm.S and
> the details of the hypervisor ABI for doing VTL Return, that are
> outside my area of expertise so I'm limited to a surface level
> review.
> 
> Reviewed-by: Michael Kelley <mhklinux@...look.com>

Thanks for the review Michael.

Regards
Naman