[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20251106171557.011333928@kernel.org>
Date: Thu, 06 Nov 2025 12:15:57 -0500
From: Steven Rostedt <rostedt@...nel.org>
To: linux-kernel@...r.kernel.org,
linux-trace-kernel@...r.kernel.org
Cc: Masami Hiramatsu <mhiramat@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
Andrew Morton <akpm@...ux-foundation.org>
Subject: [PATCH v2 0/3] tracing: Fix tracer options per instance
The tracers (like function and function_graph) have options that modify
how they behave or how they are shown in the trace file. As these options
were created before instances (multiple buffers), the flags variable that
represent these options were global for the tracer.
Now that a tracer may exist in multiple instances, having a global flags
that kinda affect every instance of that tracer does not make sense.
The reason it "kinda" affects them, is that the code that updates an option
for an instance, only does the change for the tracer running in that instance.
If a tracer is already running in another instance, it will not be affected.
But because the option is saved in a global variable, if the tracer is stopped
and restarted in the instance, then the option will take affect.
Since each instance has its own interface to modify the options, the effect
of an option should only affect the tracer for the given instance. This means
that the state of the options for each tracer must be saved for each instance
separately.
Add a new struct tracers field in the trace_array (instance descriptor) that
holds a descriptor that points to a tracer and contains its flags values. This
will be used to see what tracers are available for an instance.
Now when a tracer option is modified for an instance, it only affects the
tracer in that instance and not semi-effects the tracers in other instances.
Changes since v1: https://lore.kernel.org/linux-trace-kernel/20251105161935.206093132@kernel.org/
- Fixed build error for mistakes when selftests are configured in.
My initial tests didn't enable the self tests, and there was obvious
bugs in that part of the code.
- The first two patches were fine, so I pulled them in and they were
clean ups for this series. They are not part of v2 (as I already have
them applied).
Steven Rostedt (3):
tracing: Have tracer option be instance specific
tracing: Have function tracer define options per instance
tracing: Have function graph tracer define options per instance
----
kernel/trace/trace.c | 219 ++++++++++++++++++++++++-----------
kernel/trace/trace.h | 3 +
kernel/trace/trace_functions.c | 10 +-
kernel/trace/trace_functions_graph.c | 18 +--
4 files changed, 168 insertions(+), 82 deletions(-)
Powered by blists - more mailing lists