linux-kernel - Re: [PATCH 02/12] arch: arm64: qcom: sdm845-enchilada: Specify panel name within the compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f389bdbd-4739-48a8-9d77-31fec5580e06@kernel.org>
Date: Thu, 6 Nov 2025 18:27:30 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>, david@...t.cz
Cc: Neil Armstrong <neil.armstrong@...aro.org>,
 Jessica Zhang <jessica.zhang@....qualcomm.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Thierry Reding
 <thierry.reding@...il.com>, Sam Ravnborg <sam@...nborg.org>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>,
 Casey Connolly <casey.connolly@...aro.org>, dri-devel@...ts.freedesktop.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-msm@...r.kernel.org, phone-devel@...r.kernel.org
Subject: Re: [PATCH 02/12] arch: arm64: qcom: sdm845-enchilada: Specify panel
 name within the compatible

On 05/11/2025 01:55, Dmitry Baryshkov wrote:
> On Tue, Nov 04, 2025 at 11:16:10PM +0100, David Heidelberg via B4 Relay wrote:
>> From: David Heidelberg <david@...t.cz>
>>
>> sofef00 is name of the DDIC, it doesn't contain name of the panel used.
>> The DDIC is also paired with other panels, so make clear which panel is
>> used.
>>
>> cosmetic: sort the node.
>>
>> Signed-off-by: David Heidelberg <david@...t.cz>
>> ---
>>  arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dts | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dts b/arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dts
>> index a259eb9d45ae0..8aead6dc25e00 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dts
>> +++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dts
>> @@ -31,9 +31,9 @@ battery: battery {
>>  };
>>  
>>  &display_panel {
>> -	status = "okay";
>> +	compatible = "samsung,sofef00-ams628nw01", "samsung,sofef00";
> 
> This breaks the ABI. Please describe, why it is sensible. Other patches
> should describe whether the old DTs will continue to work or not.
> 
>>  
>> -	compatible = "samsung,sofef00";


If I read the hunk correctly, I do not see any ABI break here. What
exactly stops working or is negatively affected that it is called an ABI
break?

Best regards,
Krzysztof