linux-kernel - Re: [PATCH net-next v7 12/12] net: dsa: add driver for MaxLinear GSW1xx switch family

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c1b631eacec2f138eb44fbfa4c0ae056bafa4610.camel@siemens.com>
Date: Thu, 6 Nov 2025 17:36:45 +0000
From: "Sverdlin, Alexander" <alexander.sverdlin@...mens.com>
To: "olteanv@...il.com" <olteanv@...il.com>
CC: "andrew@...n.ch" <andrew@...n.ch>, "robh@...nel.org" <robh@...nel.org>,
	"lxu@...linear.com" <lxu@...linear.com>, "john@...ozen.org"
	<john@...ozen.org>, "davem@...emloft.net" <davem@...emloft.net>,
	"yweng@...linear.com" <yweng@...linear.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "bxu@...linear.com"
	<bxu@...linear.com>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "ajayaraman@...linear.com"
	<ajayaraman@...linear.com>, "fchan@...linear.com" <fchan@...linear.com>,
	"daniel@...rotopia.org" <daniel@...rotopia.org>, "hauke@...ke-m.de"
	<hauke@...ke-m.de>, "horms@...nel.org" <horms@...nel.org>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, "kuba@...nel.org" <kuba@...nel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, "jpovazanec@...linear.com"
	<jpovazanec@...linear.com>, "linux@...linux.org.uk" <linux@...linux.org.uk>
Subject: Re: [PATCH net-next v7 12/12] net: dsa: add driver for MaxLinear
 GSW1xx switch family

Hi Vladimir,

On Thu, 2025-11-06 at 19:29 +0200, Vladimir Oltean wrote:
> > # ip -d link show dev $dev
> > 4: lan1@...0: <NO-CARRIER,BROADCAST,MULTICAST,PROMISC,UP> mtu 1500 qdisc noqueue state DOWN mode DEFAULT group default qlen 1000
> >      link/ether 00:a0:03:ea:fe:b7 brd ff:ff:ff:ff:ff:ff promiscuity 2 allmulti 0 minmtu 68 maxmtu 2378 
> >      dsa conduit eth0 addrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535 tso_max_size 65536 tso_max_segs 65535 gro_max_size 65536 gso_ipv4_max_size 65536 gro 
> 
> It partially does, yes. The promiscuity is 2, which suggests it was
> already 1 when has_unicast_flt() started to run. The function is not
> written to expect that to happen. Although I don't yet understand why
> lan1 originally entered promiscuous mode - that is not in your logs.
> 
> This is a separate environment from the selftest with the commands ran
> manually, no? Because you can just run the selftest with "bash -x".

Yes, I tried the above manually.
Let me repeat the test after a clean boot and with "bash -x", not that
we are debugging something different from the real test...

-- 
Alexander Sverdlin
Siemens AG
www.siemens.com