linux-kernel - Re: [PATCH v3 0/4] nvme-fc: fix blktests nvme/041

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABPRKS8K8zfkbbVZYYxrLYPgAD+nhmrknkpA+57wc5TTAKwz1g@mail.gmail.com>
Date: Thu, 6 Nov 2025 10:41:36 -0800
From: Justin Tee <justintee8345@...il.com>
To: Daniel Wagner <wagi@...nel.org>
Cc: Keith Busch <kbusch@...nel.org>, Christoph Hellwig <hch@....de>, Sagi Grimberg <sagi@...mberg.me>, 
	James Smart <james.smart@...adcom.com>, 
	Shinichiro Kawasaki <shinichiro.kawasaki@....com>, Hannes Reinecke <hare@...e.de>, 
	linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	Justin Tee <justin.tee@...adcom.com>, paul.ely@...adcom.com
Subject: Re: [PATCH v3 0/4] nvme-fc: fix blktests nvme/041

Hi Daniel,

Taking a different approach than this patch set, may we see if the
following singular patch resolves the nvme/041 blktest?

[PATCH 1/1] nvme-fabrics: add ENOKEY to no retry criteria for
authentication failures

With authentication, in addition to EKEYREJECTED there is also no point in
retrying reconnects when status is ENOKEY.  Thus, add -ENOKEY as another
criteria to determine when to stop retries.

Signed-off-by: Justin Tee <justintee8345@...il.com>
---
 drivers/nvme/host/fabrics.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/host/fabrics.c b/drivers/nvme/host/fabrics.c
index 3d4d6d8e88c4..fb7765bf0cdf 100644
--- a/drivers/nvme/host/fabrics.c
+++ b/drivers/nvme/host/fabrics.c
@@ -594,7 +594,7 @@ bool nvmf_should_reconnect(struct nvme_ctrl *ctrl,
int status)
        if (status > 0 && (status & NVME_STATUS_DNR))
                return false;

-       if (status == -EKEYREJECTED)
+       if (status == -EKEYREJECTED || status == -ENOKEY)
                return false;

        if (ctrl->opts->max_reconnects == -1 ||
--
2.38.0

Regards,
Justin