linux-kernel - Re: [PATCH v3 1/2] dt-bindings: soc: qcom: Add qcom,kaanapali-imem compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c2o4iouc6sm7frcq64jmvxopv3eqvrjxievwwhiwqw6ptwfok3@4qmpfy4yij4m>
Date: Thu, 6 Nov 2025 14:24:33 -0600
From: Bjorn Andersson <andersson@...nel.org>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Cc: Krzysztof Kozlowski <krzk@...nel.org>, 
	Jingyi Wang <jingyi.wang@....qualcomm.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Konrad Dybcio <konradybcio@...nel.org>, Robert Marko <robimarko@...il.com>, 
	Das Srinagesh <quic_gurus@...cinc.com>, aiqun.yu@....qualcomm.com, tingwei.zhang@....qualcomm.com, 
	trilok.soni@....qualcomm.com, yijie.yang@....qualcomm.com, linux-arm-msm@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: soc: qcom: Add qcom,kaanapali-imem
 compatible

On Tue, Nov 04, 2025 at 03:58:27PM +0100, Konrad Dybcio wrote:
> On 11/4/25 3:52 PM, Krzysztof Kozlowski wrote:
> > On 04/11/2025 15:38, Konrad Dybcio wrote:
> >> On 11/4/25 3:37 PM, Krzysztof Kozlowski wrote:
> >>> On 04/11/2025 15:35, Konrad Dybcio wrote:
> >>>> On 11/4/25 3:26 PM, Krzysztof Kozlowski wrote:
> >>>>> This I got, but nothing here explains why you need generic compatible.
> >>>>> To re-iterate: there was no generic compatible before, now there is.
> >>>>> Writing bindings and numerous reviews from DT maintainers ask not to use
> >>>>> generic compatibles.
> >>>>
> >>>> OK so let's not worry about a generic compatible. IMEM exists since
> >>>> MSM8974 and it only had major hw updates with SM8550. They don't
> >>>> impact the software interface though, so qcom,msm8974-imem is OK.
> >>>>
> >>>> There's a separate control/status register address space for each
> >>>> instance of this IP (usually far apart from the actual SRAM pool),
> >>>> which Linux doesn't have to care about.
> >>>
> >>> Just use qcom,kaanapali-imem - that's the first device here without syscons.
> >>
> >> So we don't want to move the existing ones over?
> > 
> > This was never discussed and this patch did not do it. You cannot move
> > them, that's ABI.
> 
> I see, I implicitly assumed this would be a sweeping change.
> 
> So should the Kaanapali submitters simply send a version of this
> patch with:
> 
> - oneOf:
>   - const: qcom,kaanapali-imem
>   - items:
>     # existing big list
> 
> ?

We have 33 cases of "this is just a generic Qualcomm IMEM block", could
we just make it "qcom,imem" until there's actually a sign that it's not
a platform-independent block?

Regards,
Bjorn

> 
> I'm not a huge fan of using kaanapali as the fallback-going-forward
> since it's literally the newest platform on the shelves (or perhaps
> not even on the shelves yet..) so it's going to look funny when
> someone comes up with support for another 2013 soc.. but perhaps
> that's just how things are supposed to be
> 
> Konrad