linux-kernel - Re: [PATCH 1/6] hwrng: bcm2835 - Move MODULE_DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c6aafc19-a3ce-41b3-b3ba-f82494f9c9e9@broadcom.com>
Date: Thu, 6 Nov 2025 12:34:05 -0800
From: Florian Fainelli <florian.fainelli@...adcom.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 Olivia Mackall <olivia@...enic.com>, Herbert Xu
 <herbert@...dor.apana.org.au>,
 Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>, Ray Jui <rjui@...adcom.com>,
 Scott Branden <sbranden@...adcom.com>,
 Jesper Nilsson <jesper.nilsson@...s.com>,
 Lars Persson <lars.persson@...s.com>, "David S. Miller"
 <davem@...emloft.net>, Tom Lendacky <thomas.lendacky@....com>,
 John Allen <john.allen@....com>, Srujana Challa <schalla@...vell.com>,
 Bharat Bhushan <bbhushan2@...vell.com>
Cc: linux-crypto@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...s.com
Subject: Re: [PATCH 1/6] hwrng: bcm2835 - Move MODULE_DEVICE_TABLE() to table
 definition

On 11/6/25 08:31, Krzysztof Kozlowski wrote:
> Convention is to place MODULE_DEVICE_TABLE() immediately after
> definition of the affected table, so one can easily spot missing such.
> There is on the other hand no benefits of putting MODULE_DEVICE_TABLE()
> far away.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Reviewed-by: Florian Fainelli <florian.fainelli@...adcom.com>
--
Florian