linux-kernel - RE: [PATCH] spi: aspeed: Use devm_iounmap() to unmap devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <TYZPR06MB5203380D58961A36922E0436B2C2A@TYZPR06MB5203.apcprd06.prod.outlook.com>
Date: Thu, 6 Nov 2025 02:53:26 +0000
From: Chin-Ting Kuo <chin-ting_kuo@...eedtech.com>
To: Markus Elfring <Markus.Elfring@....de>, "linux-spi@...r.kernel.org"
	<linux-spi@...r.kernel.org>, "linux-aspeed@...ts.ozlabs.org"
	<linux-aspeed@...ts.ozlabs.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "openbmc@...ts.ozlabs.org"
	<openbmc@...ts.ozlabs.org>, Cédric Le Goater
	<clg@...hat.com>, Paul Menzel <pmenzel@...gen.mpg.de>
CC: "lkp@...el.com" <lkp@...el.com>, LKML <linux-kernel@...r.kernel.org>,
	Andrew Jeffery <andrew@...econstruct.com.au>, Joel Stanley <joel@....id.au>,
	Mark Brown <broonie@...nel.org>, BMC-SW <BMC-SW@...eedtech.com>
Subject: RE: [PATCH] spi: aspeed: Use devm_iounmap() to unmap devm_ioremap()
 memory

Hi Markus,

> -----Original Message-----
> From: Markus Elfring <Markus.Elfring@....de>
> Sent: Thursday, November 6, 2025 1:44 AM
> Subject: Re: [PATCH] spi: aspeed: Use devm_iounmap() to unmap
> devm_ioremap() memory
> 
> > The AHB IO memory for each chip select is mapped using devm_ioremap(),
> > so it should be unmapped using devm_iounmap() to ensure proper
> > device-managed resource cleanup.
> …
> 
> * You may occasionally put more than 61 characters into text lines
>   of such a change description.
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Docume
> ntation/process/submitting-patches.rst?h=v6.18-rc4#n658
> 

The line characters number is 75 instead of 61. Isn't it?

> * Would another imperative wording become helpful for an improved change
> description?
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Docume
> ntation/process/submitting-patches.rst?h=v6.18-rc4#n94
> 

How about change the description to the below one?

Use devm_iounmap() to unmap memory mapped with devm_ioremap().
This ensures proper cleanup of device-managed resources.

> 
> Regards,
> Markus