linux-kernel - Re: [PATCH v2 1/2] mfd: tps65219: Implement LOCK register handling for TPS65214

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202511070607.Il9q9meO-lkp@intel.com>
Date: Fri, 7 Nov 2025 06:18:16 +0800
From: kernel test robot <lkp@...el.com>
To: "Kory Maincent (TI.com)" <kory.maincent@...tlin.com>,
	Aaro Koskinen <aaro.koskinen@....fi>,
	Andreas Kemnade <andreas@...nade.info>,
	Kevin Hilman <khilman@...libre.com>,
	Roger Quadros <rogerq@...nel.org>, Tony Lindgren <tony@...mide.com>,
	Lee Jones <lee@...nel.org>,
	Shree Ramamoorthy <s-ramamoorthy@...com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>
Cc: oe-kbuild-all@...ts.linux.dev, Andrew Davis <afd@...com>,
	Bajjuri Praneeth <praneeth@...com>,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
	linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org,
	"Kory Maincent (TI.com)" <kory.maincent@...tlin.com>,
	stable@...r.kernel.org
Subject: Re: [PATCH v2 1/2] mfd: tps65219: Implement LOCK register handling
 for TPS65214

Hi Kory,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 1c353dc8d962de652bc7ad2ba2e63f553331391c]

url:    https://github.com/intel-lab-lkp/linux/commits/Kory-Maincent-TI-com/mfd-tps65219-Implement-LOCK-register-handling-for-TPS65214/20251106-185551
base:   1c353dc8d962de652bc7ad2ba2e63f553331391c
patch link:    https://lore.kernel.org/r/20251106-fix_tps65219-v2-1-a7d608c4272f%40bootlin.com
patch subject: [PATCH v2 1/2] mfd: tps65219: Implement LOCK register handling for TPS65214
config: i386-buildonly-randconfig-003-20251107 (https://download.01.org/0day-ci/archive/20251107/202511070607.Il9q9meO-lkp@intel.com/config)
compiler: gcc-13 (Debian 13.3.0-16) 13.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251107/202511070607.Il9q9meO-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511070607.Il9q9meO-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/mfd/tps65219.c: In function 'tps65214_reg_write':
>> drivers/mfd/tps65219.c:479:26: warning: variable 'tps' set but not used [-Wunused-but-set-variable]
     479 |         struct tps65219 *tps;
         |                          ^~~


vim +/tps +479 drivers/mfd/tps65219.c

   475	
   476	static int tps65214_reg_write(void *context, unsigned int reg, unsigned int val)
   477	{
   478		struct i2c_client *i2c = context;
 > 479		struct tps65219 *tps;
   480		int ret;
   481	
   482		if (val > 0xff || reg > 0xff)
   483			return -EINVAL;
   484	
   485		tps = i2c_get_clientdata(i2c);
   486		ret = i2c_smbus_write_byte_data(i2c, TPS65214_REG_LOCK,
   487						TPS65214_LOCK_ACCESS_CMD);
   488		if (ret)
   489			return ret;
   490	
   491		ret = i2c_smbus_write_byte_data(i2c, reg, val);
   492		if (ret)
   493			return ret;
   494	
   495		return i2c_smbus_write_byte_data(i2c, TPS65214_REG_LOCK, 0);
   496	}
   497	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki