linux-kernel - Re: linux-next-20251029

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAO=gReE5LThojtkZx3+6aJYuB7UpRs1tHVnvma+BynFduA_9Zg@mail.gmail.com>
Date: Wed, 5 Nov 2025 19:32:12 -0800
From: Amit Dhingra <mechanicalamit@...il.com>
To: Timur Kristóf <timur.kristof@...il.com>
Cc: Valdis Klētnieks <valdis.kletnieks@...edu>, 
	Alex Deucher <alexander.deucher@....com>, Leo Li <sunpeng.li@....com>, 
	David Airlie <airlied@...il.com>, amd-gfx list <amd-gfx@...ts.freedesktop.org>, 
	dri-devel <dri-devel@...ts.freedesktop.org>, linux-kernel@...r.kernel.org
Subject: Re: linux-next-20251029 - build error in amdgpu

On Thu, Nov 06, 2025 at 04:29:05AM +0100, Timur Kristóf wrote:
> On Wed, 2025-11-05 at 19:24 -0800, Amit Dhingra wrote:
> > On Thu, Nov 06, 2025 at 03:40:52AM +0100, Timur Kristóf wrote:
> > > On Wed, 2025-11-05 at 18:34 -0800, Amit Dhingra wrote:
> > > >
> > > > >
> > > > > What do I need to do to trigger the warning?
> > > > >
> > > > I have the same problem.
> > > >
> > > > linux-next on Arch Linux
> > > > GCC : 15.2.1 20250813
> > > >
> > > >
> > > > Steps to reproduce the error
> > > > - make mrproper
> > > > - make allmodconfig
> > > > - make drivers/gpu/drm/amd/amdgpu/
> > > >
> > > > Turns out its due to randconfig, See [1]
> > > >
> > > > Setting RANDSTRUCT_NONE=y seems to stop the error.
> > >
> > > Can you please try and see if this fixes the warning?
> > > https://pastebin.com/raw/b8j3UABj
> >
> > The patch above defining all fields seems to fix the error.
> >
> > >
> > > Alternatively, if anyone has other recommendations on how to fix
> > > it,
> > > I'm also open to suggestions.
> > >
> >
> > What seemed to also work for me is to defining the struct as below
> > without an initialization.
> >
> > static const struct stream_encoder_funcs dce110_an_str_enc_funcs;
> >
> > Its static so should be initialized zeroed out. objdump shows correct
> > size
> > allocation.
> >
> > objdump -x dce_stream_encoder.o
> >
> >   0000000000000b60 l     O .rodata	0000000000000130
> > dce110_str_enc_funcs
> >   0000000000000a00 l     O .rodata	0000000000000130
> > dce110_an_str_enc_funcs
> >
>
> Thanks! This looks even cleaner.
>
> I will submit a patch to fix the warning next week.
> Can I add your name and email to the Suggested-by tag?

Certainly. Thank you!!

>
> Thanks,
> Timur
>
>
>
> >
> > > Thanks,
> > > Timur
> > >
> > >
> > > > >
> > > > > Valdis Klētnieks <valdis.kletnieks@...edu> ezt írta (időpont:
> > > > > 2025.
> > > > > nov.
> > > > > 2., Vas 1:59):
> > > > >
> > > > > > On Thu, 30 Oct 2025 19:05:30 +0100, Timur Kristóf said:
> > > > > >
> > > > > > > Can you say how to reproduce that?
> > > > > > > I use the same version of GCC but it hasn't given me any
> > > > > > > warning or
> > > > > > > error for that patch.
> > > > > >
> > > > > > Upon further testing,
> > > > > >
> > > > > > [/usr/src/linux-next] make
> > > > > >
> > > > > > is sufficient on my system. Turns out that it errors out even
> > > > > > without W=1.
> > > > > > My
> > > > > > next guess was that it had to do with -Werror, which would
> > > > > > cause
> > > > > > warnings
> > > > > > to
> > > > > > be treated as errors, but my .config has
> > > > > >
> > > > > > # CONFIG_WERROR is not set
> > > > > > # CONFIG_DRM_WERROR is not set
> > > > > > # CONFIG_DRM_AMDGPU_WERROR is not set
> > > > > >
> > > > > > Do you perhaps have patches in your tree that aren't in next-
> > > > > > 20251029?
> > > > > >
> > > > > > I wonder if Fedora's build of gcc 15.2.1 is different somehow
> > > > > > from the
> > > > > > build you're using....
> > > > > >
> > > > > >
> > > > > >
> > > > > >