linux-kernel - Re: [PATCH v6 00/11] Add mt8189 dts evaluation board and Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <49022cbd70fbd06fd066872c9d9cf1919f7ff75c.camel@mediatek.com>
Date: Thu, 6 Nov 2025 05:33:50 +0000
From: Jh Hsu (許希孜) <Jh.Hsu@...iatek.com>
To: "conor@...nel.org" <conor@...nel.org>
CC: "daniel.lezcano@...aro.org" <daniel.lezcano@...aro.org>,
	"ukleinek@...nel.org" <ukleinek@...nel.org>, "tglx@...utronix.de"
	<tglx@...utronix.de>, "wim@...ux-watchdog.org" <wim@...ux-watchdog.org>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>, "jirislaby@...nel.org"
	<jirislaby@...nel.org>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "nuno.sa@...log.com" <nuno.sa@...log.com>,
	"linux-pwm@...r.kernel.org" <linux-pwm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Chunfeng Yun (云春峰) <Chunfeng.Yun@...iatek.com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"matthias.bgg@...il.com" <matthias.bgg@...il.com>,
	Andrew-CT Chen (陳智迪)
	<Andrew-CT.Chen@...iatek.com>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	"linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>,
	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
	Zhiyong Tao (陶志勇) <Zhiyong.Tao@...iatek.com>,
	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>, "andy@...nel.org"
	<andy@...nel.org>, Lala Lin (林秀芬)
	<Lala.Lin@...iatek.com>, Sean Wang <Sean.Wang@...iatek.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>, "robh@...nel.org"
	<robh@...nel.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "jic23@...nel.org"
	<jic23@...nel.org>, "dlechner@...libre.com" <dlechner@...libre.com>,
	"srini@...nel.org" <srini@...nel.org>,
	Jitao Shi (石记涛) <jitao.shi@...iatek.com>,
	Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@...iatek.com>, "linux@...ck-us.net"
	<linux@...ck-us.net>
Subject: Re: [PATCH v6 00/11] Add mt8189 dts evaluation board and Makefile

On Wed, 2025-11-05 at 18:48 +0000, Conor Dooley wrote:
> > > Please drop mention of the evb from all of these commit messages.
> > > The
> > > compatible has nothing to do with the evb board, it's going to be
> > > common
> > > across all boards using an mt8189.
> > > 
> > > >   arm64: dts: mediatek: Add MT6319 PMIC Support
> > > >   arm64: dts: mediatek: add properties for MT6359
> > > 
> > > Wait a minute, what are these two patches even doing in this
> > > series
> > > in
> > > the first place, when it is otherwise about the mt8189?
> > 
> > mt8189 evb board include mt63xx.dtsi, 
> > and the dtsi files maybe for other boards in the future, 
> > ie. mt8189/81xx custom/OEM/ODM boards.
> > Should i separate those two patches as a new patch series ?
> 
> They seemed unrelated to your series and poor quality to the point
> that
> they looked like an accidental inclusions, given there's no mention
> of
> them in the cover letter. Since they do appear to be related, sure
> keep
> them. That said, the "add properties for MT6359" patch is in need of
> major rework, so you'll have to rework it.

Got it, will add mt63xx information and rework mt63xx dtsi in next
version