linux-kernel - [PATCH net-next v3 1/4] dt-bindings: net: ftgmac100: Add delay properties for AST2600

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SEYPR06MB5134004879B45343D135FC4B9DC2A@SEYPR06MB5134.apcprd06.prod.outlook.com>
Date: Thu, 6 Nov 2025 05:41:29 +0000
From: Jacky Chou <jacky_chou@...eedtech.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Rob Herring
	<robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
	<conor+dt@...nel.org>, Po-Yu Chuang <ratbert@...aday-tech.com>, Joel Stanley
	<joel@....id.au>, Andrew Jeffery <andrew@...econstruct.com.au>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-aspeed@...ts.ozlabs.org"
	<linux-aspeed@...ts.ozlabs.org>, "taoren@...a.com" <taoren@...a.com>
Subject: [PATCH net-next v3 1/4] dt-bindings: net: ftgmac100: Add delay
 properties for AST2600

> >>> Create the new compatibles to identify AST2600 MAC0/1 and MAC3/4.
> >>> Add conditional schema constraints for Aspeed AST2600 MAC controllers:
> >>> - For "aspeed,ast2600-mac01", require rx/tx-internal-delay-ps properties
> >>>   with 45ps step.
> >>> - For "aspeed,ast2600-mac23", require rx/tx-internal-delay-ps properties
> >>>   with 250ps step.
> >>
> >> That difference does not justify different compatibles. Basically you
> >> said they have same programming model, just different hardware
> >> characteristics, so same compatible.
> >>
> >
> > This change was originally based on feedback from a previous review
> discussion.
> > At that time, another reviewer suggested introducing separate
> > compatibles for
> > MAC0/1 and MAC2/3 on AST2600, since the delay characteristics differ
> > and they might not be fully compatible.
> 
> 
> Your commit msg does not provide enough of rationale for that.
> Difference in DTS properties is rather a counter argument for having separate
> compatibles. That's why you have these properties - to mark the difference.
> 

Actually, on the AST2600 there are two dies, and each die has its own MAC.
The MACs on these two dies indeed have different delay configurations.

Previously, the driver did not configure these delays — they were set earlier during 
the bootloader stage. Now, I’m planning to use the properties defined in 
ethernet-controller.yaml to configure these delays properly within the driver.

Since these legacy settings have been used for quite some time, I’d like to deprecate 
the old compatible and clearly distinguish that the AST2600 contains two different 
MACs. Future platforms based on the AST2600 will use the new compatibles with 
the correct PHY and delay configurations.

In the next revision, I’ll also include a detailed description explaining the reason for 
this change.

Thanks again for your review.

Thanks,
Jacky