linux-kernel - Re: [PATCH 00/11] remoteproc: imx_dsp_rproc: Refactor to use new ops and remove switch-case logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aQw8emAk2tJMBjSN@shlinux89>
Date: Thu, 6 Nov 2025 14:13:14 +0800
From: Peng Fan <peng.fan@....nxp.com>
To: Peng Fan <peng.fan@....com>
Cc: Bjorn Andersson <andersson@...nel.org>,
	Mathieu Poirier <mathieu.poirier@...aro.org>,
	Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Daniel Baluta <daniel.baluta@....com>,
	Shengjiu Wang <shengjiu.wang@....com>, Frank Li <frank.li@....com>,
	Iuliana Prodan <iuliana.prodan@....com>,
	linux-remoteproc@...r.kernel.org, imx@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/11] remoteproc: imx_dsp_rproc: Refactor to use new ops
 and remove switch-case logic


After using b4 shazam to collect patches, "b4 prep --force-revision 2" was
missed to bump the version. Please let me know if I need to resend
with V2 tag.

Thanks,
Peng

On Thu, Nov 06, 2025 at 11:30:26AM +0800, Peng Fan wrote:
>This patchset aligns imx_dsp_rproc with the cleanup and modernization
>previously applied to imx_rproc.c. The goal is to simplify the driver by
>transitioning to the new ops-based method, eliminating the legacy
>switch-case logic for a cleaner and more maintainable design.
>
>Patches 1–5: General cleanup, including code simplification and adoption
>             of the devres API.
>Patches 6–10: Transition to the new ops-based approach, removing the
>              switch-case structure.
>Patch 11: Remove the obsolete enum imx_rproc_method.
>
>Signed-off-by: Peng Fan <peng.fan@....com>
>---
>Changes in v2:
>- Collected R-b
>- Patch 3: Update commit per Frank/Daniel
>- patch 8: Use priv->dsp_dcfg->dcfg to avoid adding "const struct imx_rproc_dsp_dcfg *dsp_dcfg"
>- Link to v1: https://lore.kernel.org/linux-remoteproc/CAEnQRZAOTFw=sBppHTYQAdfDBuNqkqk6gVO4FyP0EBsva3Oi+Q@mail.gmail.com/T/#m27c93af9fb1e7fdeb0766bdbffbaae39d79eefab
>
>---
>Peng Fan (11):
>      remoteproc: imx_dsp_rproc: simplify power domain attach and error handling
>      remoteproc: imx_dsp_rproc: Use devm_rproc_add() helper
>      remoteproc: imx_dsp_rproc: Use devm_pm_runtime_enable() helper
>      remoteproc: imx_dsp_rproc: Use dev_err_probe() for firmware and mode errors
>      remoteproc: imx_dsp_rproc: Drop extra space
>      remoteproc: imx_dsp_rproc: Use start/stop/detect_mode ops from imx_rproc_dcfg
>      remoteproc: imx_dsp_rproc: Move imx_dsp_rproc_dcfg closer to imx_dsp_rproc_of_match
>      remoteproc: imx_dsp_rproc: Simplify IMX_RPROC_MMIO switch case
>      remoteproc: imx_dsp_rproc: Simplify IMX_RPROC_SCU_API switch case
>      remoteproc: imx_dsp_rproc: Simplify IMX_RPROC_RESET_CONTROLLER switch case
>      remoteproc: imx_rproc: Remove enum imx_rproc_method
>
> drivers/remoteproc/imx_dsp_rproc.c | 342 ++++++++++++++++++++-----------------
> drivers/remoteproc/imx_rproc.h     |  14 --
> 2 files changed, 182 insertions(+), 174 deletions(-)
>---
>base-commit: 84d39fb9d529f27d2f3d295430d1be0abdae7a6d
>change-id: 20251106-imx-dsp-2025-11-06-bfe458cfc24c
>
>Best regards,
>-- 
>Peng Fan <peng.fan@....com>
>