lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <2025110649-elves-steadying-a4d0@gregkh>
Date: Thu, 6 Nov 2025 16:51:28 +0900
From: Greg KH <gregkh@...uxfoundation.org>
To: Clint George <clintbgeorge@...il.com>
Cc: arnd@...db.de, linux-kernel-mentees@...ts.linux.dev,
	skhan@...uxfoundation.org, khalid@...nel.org,
	david.hunter.linux@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hangcheck-timer: use pr_crit and fix coding style

On Wed, Nov 05, 2025 at 07:35:41PM +0530, Clint George wrote:
> Fix coding style issues and improve logging in hangcheck-timer such as replace printk(KERN_CRIT ...) to pr_crit(...) where applicable and replace non-standard %Ld with %lld in debug prints and use proper pr_debug/pr_crit for kernel logging.

Please wrap changelog comments at 72 columns.

Also, please split this up into "one patch per logical thing", as you
shouldn't be mixing them into one change.


thanks,

greg k-h

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ