linux-kernel - Re: [PATCH 5/5] arm64: dts: qcom: sc8280xp: Add missing VDD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <25e8453b-91fb-49f2-a61b-fd7b3267e558@oss.qualcomm.com>
Date: Thu, 6 Nov 2025 14:44:58 +0530
From: Imran Shaik <imran.shaik@....qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
 <conor+dt@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Johan Hovold <johan+linaro@...nel.org>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Manivannan Sadhasivam <mani@...nel.org>, Vinod Koul <vkoul@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd
 <sboyd@...nel.org>, Taniya Das <quic_tdas@...cinc.com>,
        Imran Shaik <quic_imrashai@...cinc.com>,
        Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>,
        Jagadeesh Kona <quic_jkona@...cinc.com>,
        Ulf Hansson
 <ulf.hansson@...aro.org>,
        Bryan O'Donoghue <bryan.odonoghue@...aro.org>
Cc: Krzysztof Kozlowski <krzk@...nel.org>, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-remoteproc@...r.kernel.org, linux-clk@...r.kernel.org,
        linux-pm@...r.kernel.org,
        Jagadeesh Kona <jagadeesh.kona@....qualcomm.com>
Subject: Re: [PATCH 5/5] arm64: dts: qcom: sc8280xp: Add missing VDD_MXC links



On 11/5/2025 4:32 PM, Konrad Dybcio wrote:
> On 11/5/25 10:21 AM, Imran Shaik wrote:
>>
>>
>> On 11/5/2025 1:01 AM, Konrad Dybcio wrote:
>>> From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
>>>
>>> To make sure that power rail is voted for, wire it up to its consumers.
>>>
>>> Fixes: 9bd07f2c558f ("arm64: dts: qcom: sc8280xp: Add in CAMCC for sc8280xp")
>>> Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform")
>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
>>> ---
>>>  arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 22 ++++++++++++++++------
>>>  1 file changed, 16 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
>>> index 5334adebf278..643a61cc91b4 100644
>>> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
>>> @@ -4586,8 +4586,10 @@ camcc: clock-controller@...0000 {
>>>  				 <&rpmhcc RPMH_CXO_CLK>,
>>>  				 <&rpmhcc RPMH_CXO_CLK_A>,
>>>  				 <&sleep_clk>;
>>> -			power-domains = <&rpmhpd SC8280XP_MMCX>;
>>> -			required-opps = <&rpmhpd_opp_low_svs>;
>>> +			power-domains = <&rpmhpd SC8280XP_MMCX>,
>>> +					<&rpmhpd SC8280XP_MXC>;
>>
>> I see that none of the CAMCC PLLs/clocks are on MXC rail on SC8280XP target.
>> So, MXC support is not required for CAMCC.
> 
> Hm, to the extent that camss is supported upstream, I could indeed
> boot without pd_ignore_unused and the camera actually kept working..
> 
> I see in docs that there are links between MXC and various IPs within
> camera so I'm a little confused. Would you know more?
> 

Not sure on the rail requirements from the camera core side, but from the
camera clock controller side, we don't need the MXC support.

Thanks,
Imran

> 
> I wasn't able to test venus because it locks up either way..
> 
> Konrad