linux-kernel - Re: [PATCH] rust: io: cleanup imports and use "kernel vertical" style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251106114622.18ed7628.zhiw@nvidia.com>
Date: Thu, 6 Nov 2025 11:46:22 +0200
From: Zhi Wang <zhiw@...dia.com>
To: Danilo Krummrich <dakr@...nel.org>
CC: <aliceryhl@...gle.com>, <daniel.almeida@...labora.com>,
	<ojeda@...nel.org>, <alex.gaynor@...il.com>, <boqun.feng@...il.com>,
	<gary@...yguo.net>, <bjorn3_gh@...tonmail.com>, <lossin@...nel.org>,
	<a.hindborg@...nel.org>, <tmgross@...ch.edu>,
	<rust-for-linux@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] rust: io: cleanup imports and use "kernel vertical"
 style

On Tue, 4 Nov 2025 17:25:11 +0100
Danilo Krummrich <dakr@...nel.org> wrote:

> On 11/4/25 2:32 PM, Danilo Krummrich wrote:
> > diff --git a/rust/kernel/io/poll.rs b/rust/kernel/io/poll.rs
> > index ebc29023d59d..e21ccf98b81a 100644
> > --- a/rust/kernel/io/poll.rs
> > +++ b/rust/kernel/io/poll.rs
> > @@ -5,7 +5,10 @@
> >  //! C header:
> > [`include/linux/iopoll.h`](srctree/include/linux/iopoll.h). 
> >  use crate::{
> > -    error::{code::*, Result},
> > +    error::{
> > +        code::*,
> > +        Result, //
> > +    },
> >      processor::cpu_relax,
> >      task::might_sleep,
> >      time::{
> 
> Should instead be:
> 

LGTM. Tested on the driver-core-testing branch with this extra change.

Reviewed-by: Zhi Wang <zhiw@...dia.com>

> diff --git a/rust/kernel/io/poll.rs b/rust/kernel/io/poll.rs
> index ebc29023d59d..b1a2570364f4 100644
> --- a/rust/kernel/io/poll.rs
> +++ b/rust/kernel/io/poll.rs
> @@ -5,7 +5,7 @@
>  //! C header:
> [`include/linux/iopoll.h`](srctree/include/linux/iopoll.h).
> 
>  use crate::{
> -    error::{code::*, Result},
> +    prelude::*,
>      processor::cpu_relax,
>      task::might_sleep,
>      time::{
>