linux-kernel - Re: [PATCH] ASoC: codecs: va-macro: fix resource leak in probe error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <04ef8cb6-8d0e-434b-adee-b7e32a6e0b8c@oss.qualcomm.com>
Date: Thu, 6 Nov 2025 11:00:28 +0100
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Haotian Zhang <vulab@...as.ac.cn>, srinivas.kandagatla@...aro.org,
        lgirdwood@...il.com, broonie@...nel.org, perex@...ex.cz,
        tiwai@...e.com
Cc: linux-sound@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: codecs: va-macro: fix resource leak in probe error
 path

On 11/6/25 8:50 AM, Haotian Zhang wrote:
> In the commit referenced by the Fixes tag, clk_hw_get_clk()
> was added in va_macro_probe() to get the fsgen clock,
> but forgot to add the corresponding clk_put() in va_macro_remove().
> This leads to a clock reference leak when the driver is unloaded.
> 
> Add clk_put() call in va_macro_remove() to properly release the clock
> reference obtained in probe.
> 
> Fixes: 30097967e056 ("ASoC: codecs: va-macro: use fsgen as clock")
> Signed-off-by: Haotian Zhang <vulab@...as.ac.cn>
> ---

You can switch the clk_hw_get_clk to devm_clk_hw_get_clk() instead

Konrad