linux-kernel - Re: [PATCH] dt-bindings: panel: s6e3fc2x01: Sort and remove unnecessary properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f61b9148-3551-4670-86b7-8842592a38a4@ixit.cz>
Date: Thu, 6 Nov 2025 11:56:31 +0100
From: David Heidelberg <david@...t.cz>
To: Krzysztof Kozlowski <krzk@...nel.org>,
 Neil Armstrong <neil.armstrong@...aro.org>,
 Jessica Zhang <jesszhan0024@...il.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, phone-devel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: panel: s6e3fc2x01: Sort and remove
 unnecessary properties

On 06/11/2025 11:46, Krzysztof Kozlowski wrote:
> On 06/11/2025 11:36, David Heidelberg via B4 Relay wrote:
>> From: David Heidelberg <david@...t.cz>
>>
>> Properties are now sorted, reset-gpio and port property dropped.
> 
> You need to explain why. Sorting is kind of obvious, but dropping
> property is not.
> 
> "... because they are already accepted here as part of panel-common and
> usage of unevaluatedProperties.".
> 
> Or just "because they are redundant." if you think reason for redundancy
> is obvious.

Yeah, I fight with this a bit, when I get suggestion from reviewer 
implying something needs to be changed, my brain auto-magically assumes 
everyone understand why.

I'll try to switch to the mind of "regular commit reader" and think 
about it for next messages.

Version 2 sent, thanks!>
>>
>> Fixes: 986f28f3a71e ("dt-bindings: panel: Add Samsung S6E3FC2X01 DDIC with panel")
> 
> No issue/bug to fix here, it's just style. Please drop.
> 
> Best regards,
> Krzysztof
-- 
David Heidelberg