linux-kernel - Re: [PATCH v2 5/7] reset: eyeq: drop device_set_of_node_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9506997c56808cc9fd58fe0d384976421d6c9bfc.camel@pengutronix.de>
Date: Thu, 06 Nov 2025 11:51:27 +0100
From: Philipp Zabel <p.zabel@...gutronix.de>
To: Théo Lebrun <theo.lebrun@...tlin.com>, Vladimir
 Kondratiev <vladimir.kondratiev@...ileye.com>, Grégory
 Clement	 <gregory.clement@...tlin.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Vinod Koul <vkoul@...nel.org>,  Kishon Vijay Abraham
 I	 <kishon@...nel.org>, Michael Turquette <mturquette@...libre.com>,
 Stephen Boyd	 <sboyd@...nel.org>, Thomas Bogendoerfer
 <tsbogend@...ha.franken.de>
Cc: linux-mips@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-phy@...ts.infradead.org, 
	linux-clk@...r.kernel.org, Benoît Monin	
 <benoit.monin@...tlin.com>, Maxime Chevallier
 <maxime.chevallier@...tlin.com>,  Tawfik Bayouk
 <tawfik.bayouk@...ileye.com>, Thomas Petazzoni
 <thomas.petazzoni@...tlin.com>, Jerome Brunet	 <jbrunet@...libre.com>
Subject: Re: [PATCH v2 5/7] reset: eyeq: drop device_set_of_node_from_dev()
 done by parent

On Sa, 2025-11-01 at 09:53 +0100, Théo Lebrun wrote:
> Our parent driver (clk-eyeq) now does the
> 	device_set_of_node_from_dev(dev, dev->parent)
> call through the newly introduced devm_auxiliary_device_create() helper.
> 
> Doing it again in the reset-eyeq probe would be redundant.
> Drop both the WARN_ON() and the device_set_of_node_from_dev() call.
> Also fix the following comment that talks about "our newfound OF node".
> 
> Signed-off-by: Théo Lebrun <theo.lebrun@...tlin.com>
> Signed-off-by: Jerome Brunet <jbrunet@...libre.com>

Reviewed-by: Philipp Zabel <p.zabel@...gutronix.de>

and

Acked-by: Philipp Zabel <p.zabel@...gutronix.de>

to be merged via the clk tree together with patch 3.

regards
Philipp