linux-kernel - Re: [Intel-wired-lan] [PATCH v2] net: ethernet: fix uninitialized pointers with free attr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f3c89a9182387cd0df012726fc30841aae8d330d.camel@gmail.com>
Date: Thu, 06 Nov 2025 17:07:29 +0530
From: ally heev <allyheev@...il.com>
To: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>, "Nguyen, Anthony
 L" <anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
 <przemyslaw.kitszel@...el.com>,  Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet	
 <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni	
 <pabeni@...hat.com>, "K. Y. Srinivasan" <kys@...rosoft.com>, Haiyang Zhang	
 <haiyangz@...rosoft.com>, Wei Liu <wei.liu@...nel.org>, "Cui, Dexuan"	
 <decui@...rosoft.com>
Cc: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>, 
 "netdev@...r.kernel.org"
	 <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	 <linux-kernel@...r.kernel.org>, "linux-hyperv@...r.kernel.org"
	 <linux-hyperv@...r.kernel.org>, Dan Carpenter <dan.carpenter@...aro.org>
Subject: Re: [Intel-wired-lan] [PATCH v2] net: ethernet: fix uninitialized
 pointers with free attr

On Thu, 2025-11-06 at 10:18 +0000, Loktionov, Aleksandr wrote:
[..]
> Code style:
> The new declaration + initializer is good, but please ensure both hunks stay within ~80 columns in drivers/net/*.
> Wrapping like this is fine:
> 
> struct ice_flow_prof_params *params __free(kfree) =
>         kzalloc(sizeof(*params), GFP_KERNEL);

I ran checkpatch with `$max_line_length` set to 80. It didn't throw any errors/warnings

Regards,
Ally