linux-kernel - Re: [PATCH v5 09/17] vfs: clean up argument list for vfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fc9765e8c58fbbc14c8066f685477da0cb2b55d0.camel@kernel.org>
Date: Thu, 06 Nov 2025 07:08:59 -0500
From: Jeff Layton <jlayton@...nel.org>
To: NeilBrown <neil@...wn.name>
Cc: Miklos Szeredi <miklos@...redi.hu>, Alexander Viro
 <viro@...iv.linux.org.uk>,  Christian Brauner	 <brauner@...nel.org>, Jan
 Kara <jack@...e.cz>, Chuck Lever	 <chuck.lever@...cle.com>, Alexander Aring
 <alex.aring@...il.com>, Trond Myklebust <trondmy@...nel.org>, Anna
 Schumaker <anna@...nel.org>, Steve French <sfrench@...ba.org>,  Paulo
 Alcantara	 <pc@...guebit.org>, Ronnie Sahlberg <ronniesahlberg@...il.com>,
 Shyam Prasad N	 <sprasad@...rosoft.com>, Tom Talpey <tom@...pey.com>,
 Bharath SM	 <bharathsm@...rosoft.com>, Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>,  "Rafael J. Wysocki"	 <rafael@...nel.org>,
 Danilo Krummrich <dakr@...nel.org>, David Howells	 <dhowells@...hat.com>,
 Tyler Hicks <code@...icks.com>, Olga Kornievskaia	 <okorniev@...hat.com>,
 Dai Ngo <Dai.Ngo@...cle.com>, Amir Goldstein	 <amir73il@...il.com>, Namjae
 Jeon <linkinjeon@...nel.org>, Steve French	 <smfrench@...il.com>, Sergey
 Senozhatsky <senozhatsky@...omium.org>, Carlos Maiolino <cem@...nel.org>,
 Kuniyuki Iwashima <kuniyu@...gle.com>, "David S. Miller"	
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski	
 <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman	
 <horms@...nel.org>, linux-fsdevel@...r.kernel.org,
 linux-kernel@...r.kernel.org, 	linux-nfs@...r.kernel.org,
 linux-cifs@...r.kernel.org, 	samba-technical@...ts.samba.org,
 netfs@...ts.linux.dev, ecryptfs@...r.kernel.org, 
	linux-unionfs@...r.kernel.org, linux-xfs@...r.kernel.org,
 netdev@...r.kernel.org
Subject: Re: [PATCH v5 09/17] vfs: clean up argument list for vfs_create()

On Thu, 2025-11-06 at 08:27 +1100, NeilBrown wrote:
> On Thu, 06 Nov 2025, Jeff Layton wrote:
> > As Neil points out:
> > 
> > "I would be in favour of dropping the "dir" arg because it is always
> > d_inode(dentry->d_parent) which is stable."
> > 
> > ...and...
> > 
> > "Also *every* caller of vfs_create() passes ".excl = true".  So maybe we
> > don't need that arg at all."
> > 
> > Drop both arguments from vfs_create() and fix up the callers.
> > 
> > Suggested-by: NeilBrown <neilb@...mail.net>
> > Signed-off-by: Jeff Layton <jlayton@...nel.org>
> 
> This I like.
> 
> Reviewed-by: NeilBrown <neil@...wn.name>
> 
> It would be consistent to also remove the 'dir' arg from vfs_mkdir(),
> vfs_mknod(), etc.  I wouldn't do that until we find out what other
> people think of the change.
> 

I was thinking that too. I can roll patches to do those as well, but at
this point I think I'd rather do that on top of this series rather than
in the context of it.
-- 
Jeff Layton <jlayton@...nel.org>