linux-kernel - Re: [PATCH 1/4] platform: arm64: thinkpad-t14s-ec: fix IRQ race condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cb0b090e-ce50-48d9-a90b-ffba3b22a49a@kernel.org>
Date: Thu, 6 Nov 2025 01:40:22 +0000
From: Bryan O'Donoghue <bod@...nel.org>
To: Sebastian Reichel <sre@...nel.org>, Hans de Goede <hansg@...nel.org>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] platform: arm64: thinkpad-t14s-ec: fix IRQ race
 condition

On 05/11/2025 23:22, Sebastian Reichel wrote:
> Fix a race condition, that an input key related interrupt might be
> triggered before the input handler has been registered, which results
> in a NULL pointer dereference. This can happen if the user enables
> the keyboard backlight shortly before the driver is being probed.
> 
> Fixes: 60b7ab6ce030 ("platform: arm64: thinkpad-t14s-ec: new driver")
> Signed-off-by: Sebastian Reichel <sre@...nel.org>
> ---
Enabling interrupts late in probe seems like a bit of a no-brainer.

One thing though is the commit log might productively contain the 
backtrace so that people can match bug fixes to specific backtraces.

Reviewed-by: Bryan O'Donoghue <bod@...nel.org>