linux-kernel - Re: [PATCH] char: xillybus: add WQ_PERCPU to alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAofZF4D6ML8Yvckfv231PXTtKf40H2De2xZ+uS23C70S5zvhA@mail.gmail.com>
Date: Fri, 7 Nov 2025 15:57:00 +0100
From: Marco Crivellari <marco.crivellari@...e.com>
To: Eli Billauer <eli.billauer@...il.com>
Cc: linux-kernel@...r.kernel.org, Tejun Heo <tj@...nel.org>, 
	Lai Jiangshan <jiangshanlai@...il.com>, Frederic Weisbecker <frederic@...nel.org>, 
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>, Michal Hocko <mhocko@...e.com>, Arnd Bergmann <arnd@...db.de>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] char: xillybus: add WQ_PERCPU to alloc_workqueue users

On Fri, Nov 7, 2025 at 3:53 PM Eli Billauer <eli.billauer@...il.com> wrote:
>
> Hello Marco,
>
> Thanks for this heads-up. Frankly speaking, I wasn't aware that the said
> calls to alloc_workqueue() implicitly bind the queue to a CPU, and this
> was never my intention. I agree that the better choice is an unbound
> queue, at least in this case.
>
> This seems to be an example for why the API change of alloc_workqueue()
> is a good idea.
>
> As for the patch itself, it perpetuates the incorrect choice, so I vote
> against. If anything, WQ_UNBOUND should be added, but since it's going
> to be the default (soon?), maybe just let it be, and let the planned
> change in the API rectify this.
>
> Thanks,
>    Eli

Hello Eli,

Considering this workload has no benefit being per-cpu, it's not a problem
send a v2 converting this with WQ_UNBOUND, in the meantime.
 I've done the same for other subsystems. :-)

Thanks!

-- 

Marco Crivellari

L3 Support Engineer, Technology & Product